Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58781

Inconsistency in feedback analysis displayed on the web and exported to the excel

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.6, 3.2.3, 3.3, 3.4.3, 3.5, 3.6
    • Fix Version/s: 3.4.6, 3.5.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      As admin or teacher:

      1. Create a feedback activity in a course
      2. Add some questions to feedback activity
      3. While there's no response for feedback activity
      4. Go to feedback activity and click in 'Analysis' tab
      5. Click on 'Export to Excel'
      6. Open downloaded Excel file and check second row title is 'Submitted answers: 0'

      As student:

      1. Submit feedback to new activity

      As admin or teacher:

      1. Now there's some feedback submitted
      2. Go to feedback activity and click in 'Analysis' tab
      3. Click in 'Export to Excel'
      4. Open downloaded Excel file and check second row title is 'Submitted answers' and value is same you can see in web view.

       

      Show
      As admin or teacher: Create a feedback activity in a course Add some questions to feedback activity While there's no response for feedback activity Go to feedback activity and click in 'Analysis' tab Click on 'Export to Excel' Open downloaded Excel file and check second row title is 'Submitted answers: 0' As student: Submit feedback to new activity As admin or teacher: Now there's some feedback submitted Go to feedback activity and click in 'Analysis' tab Click in 'Export to Excel' Open downloaded Excel file and check second row title is 'Submitted answers' and value is same you can see in web view.  
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-58781_master

      Description

      Discovered while testing MDL-55468:

      In the Feedback module, the Analysis tab displays the number of submitted feedbacks via a string like "Submitted answers: 6" (string "completed_feedbacks") But in the exported sheet, this number is displayed as "Feedback: 6" (course module name).

      It seems to be a mistake as using the name of the module may not make sense in some other languages. I would expect the sheet uses the same string "Submitted answers: 6".

      Additionally, it seems that web UI (analysis.php) uses count_completed_responses() method for this number, and the Excel sheet displays the result of feedback_get_completeds_group_count(). Is this intentional?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              amaia Amaia Anabitarte
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              Sara Arjona (@sarjona)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m