Loading...

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE
Fixed Branches:
MOODLE_33_STABLE
Pull from Repository:
git://github.com/junpataleta/moodle.git
Pull Main Branch:
~~MDL-58794~~-master
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/932bc91cb4...MDL-58794-master
Workaround:

Hide

Use 64bits for running tests :-P
(joking, it's a need to have at least 1 32 bits run!!)

Show
Use 64bits for running tests :-P (joking, it's a need to have at least 1 32 bits run!!)
Testing Instructions:
Hide

PHPUnit

Run PHPUnit for the core_course_externallib_testcase on Windows 32-bit with PHP5.6 and PHP7.

vendor/bin/phpunit -c course core_course_externallib_testcase course/tests/externallib_test.php

Confirm everything passes.
Show
PHPUnit Run PHPUnit for the core_course_externallib_testcase on Windows 32-bit with PHP5.6 and PHP7. vendor/bin/phpunit -c course core_course_externallib_testcase course/tests/externallib_test.php Confirm everything passes.

Initially I thought this was because of my old mssql driver... (freetds 0.95)

But I've been able to reproduce the same with postgres:

So, this needs to be investigated. Before release.

Would be great to confirm if it's restricted to windows, to php 5.6... if it's only me... and then look for a fix.

is a regression caused by

MDL-58720 Course modules with access restrictions are not being returned by core_course_get_contents

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), John Okely, Jun Pataleta