Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58817

LTI icons are overwritten

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log into your site as an administrator.
      2. Visit 'Site administration' > 'Plugins' > 'Activity modules' > 'Manage activities'.
      3. Click 'Settings' next to 'External tool'.
      4. Click 'Add preconfigured tool'.
      5. Click on 'Show more'.
      6. Set the 'Icon URL' and 'Secure icon URL' to 'http://www.photographers247.co.uk/app/webroot/files/uploadimagesimage/Professional%20Cat%20Photographer%20small.jpg'
      7. Set the 'Tool URL' to 'https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml'.
      8. Click 'Save changes'
      9. Edit the external tool again.
      10. Confirm the 'Icon URL' and 'Secure icon URL' remain to what they were earlier.
      Show
      Log into your site as an administrator. Visit 'Site administration' > 'Plugins' > 'Activity modules' > 'Manage activities'. Click 'Settings' next to 'External tool'. Click 'Add preconfigured tool'. Click on 'Show more'. Set the 'Icon URL' and 'Secure icon URL' to 'http://www.photographers247.co.uk/app/webroot/files/uploadimagesimage/Professional%20Cat%20Photographer%20small.jpg' Set the 'Tool URL' to 'https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml'. Click 'Save changes' Edit the external tool again. Confirm the 'Icon URL' and 'Secure icon URL' remain to what they were earlier.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull 3.3 Branch:
      mdl58817-moodle33
    • Pull 3.4 Branch:
      mdl58817-moodle34
    • Pull Master Branch:
      mdl58817-master

      Description

      In MDL-54702, support for icons when 'Creating a tool manually as site admin' is as follows:

      • This method ignores the cartridge values entirely and allows for manual configuration of icon URLs.

      I have added an Echo360 ALP tool and although the settings page appears to let me enter icon urls, after saving they revert back to 'https://echo360qa.org/assets/images/echo360_logo_green.png'.

      This image appears squashed and ugly in our theme. In addition, the image use is inconsistent:

      1. Activity link - uses https://echo360qa.org/assets/images/echo360_logo_green.png
      2. Activity chooser - uses root/theme/image.php?theme=themename&component=lti&image=icon

       

        Attachments

        1. icon1.png
          icon1.png
          37 kB
        2. icon2.png
          icon2.png
          75 kB
        3. image-2017-11-13-01-08-09-643.png
          image-2017-11-13-01-08-09-643.png
          107 kB

          Activity

            People

            • Votes:
              5 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18