Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58833

Unit test failures if a /templates directory exists on disk

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.3, 3.3
    • Fix Version/s: 3.2.4
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide
      1. Create /templates directory:

        sudo mkdir /templates
        

      2. Run unit test:

        vendor/bin/phpunit tool_templatelibrary_external_testcase admin/tool/templatelibrary/tests/externallib_test.php
        

      Show
      Create /templates directory: sudo mkdir /templates Run unit test: vendor/bin/phpunit tool_templatelibrary_external_testcase admin/tool/templatelibrary/tests/externallib_test.php
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-58833-master

      Description

      The admin/tool/templatelibrary/classes/api.php tool_templatelibrary\api::list_templates function is not strict enough. If there's a /templates directory on disk, it causes an unrelated unit test failure.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            David Monllaó
            Tester:
            John Okely
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17