Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 3.2.3, 3.3
-
Fix Version/s: 3.2.4
-
Component/s: Authentication
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_32_STABLE, MOODLE_33_STABLE
-
Fixed Branches:MOODLE_32_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-58836-master -
Pull Master Diff URL:
Description
Auth plugins returning a custom form in their signup_form() method are completely broken. See:
https://github.com/moodle/moodle/commit/99061152af3976dc276777463328a1295a65d4cb#diff-340ce5e25da3b0932028e010bbfccdd6L95
Core renderer obviously does not have a render_my_custom_form_name() method, hence fatal error.
Problem 2 (smaller but still annoying)
if $CFG->auth_instructions is empty the link to sign up is not displayed at all (as coded in the template). However $CFG->auth_instructions is optional and its description says:
"Leave this blank for the default login instructions to be displayed on the login page. If you want to provide custom login instructions, enter them here."