Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58836

Authentication plugins providing custom signup form are completely broken

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58836-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      Test 1 - auth plugin returns a renderable from core:

      Enable email based self registration. Log out. On the login page you should see the "Is this your first time here" instructions (even with no auth instructions set). Follow "Create new account" to see the signup form. It should display a form.

      Test 2 - auth plugin returns a renderable that needs it's own renderer

      Apply the patch 0001-TEST-1.patch

      View the signup form (you should get a winning feeling and see no errors).

      Test 3 - auth plugin returns a standard mform.

      Remove the last patch and apply 0001-TEST-2.patch

      View the signup form (you should get a winning feeling and see no errors).

      Show
      Test 1 - auth plugin returns a renderable from core: Enable email based self registration. Log out. On the login page you should see the "Is this your first time here" instructions (even with no auth instructions set). Follow "Create new account" to see the signup form. It should display a form. Test 2 - auth plugin returns a renderable that needs it's own renderer Apply the patch 0001-TEST-1.patch View the signup form (you should get a winning feeling and see no errors). Test 3 - auth plugin returns a standard mform. Remove the last patch and apply 0001-TEST-2.patch View the signup form (you should get a winning feeling and see no errors).

      Description

      Auth plugins returning a custom form in their signup_form() method are completely broken. See:
      https://github.com/moodle/moodle/commit/99061152af3976dc276777463328a1295a65d4cb#diff-340ce5e25da3b0932028e010bbfccdd6L95
      Core renderer obviously does not have a render_my_custom_form_name() method, hence fatal error.

      Problem 2 (smaller but still annoying)
      if $CFG->auth_instructions is empty the link to sign up is not displayed at all (as coded in the template). However $CFG->auth_instructions is optional and its description says:
      "Leave this blank for the default login instructions to be displayed on the login page. If you want to provide custom login instructions, enter them here."

        Attachments

          Activity

            People

            Assignee:
            damyon Damyon Wiese
            Reporter:
            marina Marina Glancy
            Peer reviewer:
            Marina Glancy Marina Glancy
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Ankit Agarwal Ankit Agarwal
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17