-
Bug
-
Resolution: Won't Do
-
Minor
-
None
-
3.3, 3.4.3, 3.5, 3.6
-
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
-
-
In -- FontAwesome was added as an icon system to be used by a theme if desired. The title of the issue is 'Use the Font Awesome icon font for all icons in Moodle' however the function 'M.core.dock.ensureMoveToIconExists' in '/lib/yui/src/dock/js/loader.js':MDL-40759
{code}
M.core.dock.ensureMoveToIconExists = function(blocknode) {
if (blocknode.one('.moveto')) {
return true;
}
var commands,
moveto = Y.Node.create('<input type="image" class="moveto customcommand requiresjs" />'),
blockaction = blocknode.one('.block_action'),
icon = 't/block_to_dock',
titleh2 = blocknode.one('.header .title h2');
// Must set the image src separately of we get an error with XML strict headers
if (Y.one(document.body).hasClass('dir-rtl')) {
icon = icon + '_rtl';
}
moveto.setAttribute('alt', M.util.get_string('addtodock', 'block'));
if (titleh2) {
moveto.setAttribute('title', Y.Escape.html(M.util.get_string('dockblock', 'block', titleh2.getHTML())));
}
moveto.setAttribute('src', M.util.image_url(icon, 'moodle'));
.....
{code}
ignores this and injects an image directly rather than implementing the intent of the theme configuration setting: $THEME->iconsystem = \core\output\icon_system::FONTAWESOME;
Therefore 'Use the Font Awesome icon font for all icons in Moodle' is false and incomplete.