Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58850

Block expand / collapse not using FontAwesome when set by the theme.

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.3
    • Fix Version/s: None
    • Component/s: Blocks
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Edit the Clean theme config.php file and add '$THEME->iconsystem = \core\output\icon_system::FONTAWESOME;' at the bottom.
      2. Purge all caches.
      3. Login as an administrator.
      4. Navigate to the Dashboard.
      5. On the 'Navigation' block, expand 'My courses'.
      6. Observe the use of the FontAwesome fa-chevron-right icon.
      7. On the 'Administration' block, expand 'Site adminstration'.
      8. Observe the use of the FontAwesome fa-chevron-right icon.
      9. Repeat for collapsed of these tree items.
      Show
      Edit the Clean theme config.php file and add '$THEME->iconsystem = \core\output\icon_system::FONTAWESOME;' at the bottom. Purge all caches. Login as an administrator. Navigate to the Dashboard. On the 'Navigation' block, expand 'My courses'. Observe the use of the FontAwesome fa-chevron-right icon. On the 'Administration' block, expand 'Site adminstration'. Observe the use of the FontAwesome fa-chevron-right icon. Repeat for collapsed of these tree items.
    • Workaround:
      Hide

      In a theme provide FontAwesome alternatives via use of ':before' pseudoselector and 'display: none' the block CSS.

      Show
      In a theme provide FontAwesome alternatives via use of ':before' pseudoselector and 'display: none' the block CSS.
    • Affected Branches:
      MOODLE_33_STABLE

      Description

      In MDL-40759 FontAwesome was added as an icon system to be used by a theme if desired. The title of the issue is 'Use the Font Awesome icon font for all icons in Moodle' however with a block that uses the expand / collapse icons for trees this does not happen.  Such as the Navigation and Administration blocks.  There is CSS such as:

      {code}

      .block_settings .block_tree [aria-expanded="true"] {
          background-image: url('[[pix:t/expanded]]');
      }

      {code}

      resulting in:

      {code}

      .block_settings .block_tree [aria-expanded="true"] {

          background-image: url(/theme/image.php/clean/core/1494260791/t/expanded);
      }
      {code}
      And no FontAwesome alternative has been provided.

      Therefore 'Use the Font Awesome icon font for all icons in Moodle' is false and incomplete.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  gb2048 Gareth J Barnard
                  Participants:
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated: