Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58863

Scorm player <noscript> vs <div class="forcejavascriptmessage">

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.2, 3.3
    • 3.4
    • Accessibility, SCORM
    • MOODLE_32_STABLE, MOODLE_33_STABLE
    • MOODLE_34_STABLE
    • master_MDL-58863
    • Hide

      While viewing SCORM entry page (view.php) disable the CSS but keep JavaScript enabled and check to make sure the message "JavaScript is required to view this object, please enable JavaScript in your browser and try again." does not appear on the page.
      Disable Javascript and make sure the message does appear.

      Enter the SCORM package (player.php page) and disable CSS but keep javascript enabled, make sure the message does not appear. Disable Javascript in the browser and make sure the message does appear.

      Show
      While viewing SCORM entry page (view.php) disable the CSS but keep JavaScript enabled and check to make sure the message "JavaScript is required to view this object, please enable JavaScript in your browser and try again." does not appear on the page. Disable Javascript and make sure the message does appear. Enter the SCORM package (player.php page) and disable CSS but keep javascript enabled, make sure the message does not appear. Disable Javascript in the browser and make sure the message does appear.

    Description

      In https://github.com/moodle/moodle/blob/master/mod/scorm/player.php#L269 we can see that the scorm player generate a div block with the class "forcejavascriptmessage" instead of using a <noscript> tag that essentialy do the same thing.

      This came to my view after an accessibility audit we had.

       

      Attachments

        Activity

          People

            danmarsden Dan Marsden
            tazoeur Guillaume Latour
            Simey Lameze Simey Lameze
            David Monllaó David Monllaó
            Marina Glancy Marina Glancy
            Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/Nov/17