Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58863

Scorm player <noscript> vs <div class="forcejavascriptmessage">

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.3
    • Fix Version/s: 3.4
    • Component/s: Accessibility, SCORM
    • Labels:
    • Testing Instructions:
      Hide

      While viewing SCORM entry page (view.php) disable the CSS but keep JavaScript enabled and check to make sure the message "JavaScript is required to view this object, please enable JavaScript in your browser and try again." does not appear on the page.
      Disable Javascript and make sure the message does appear.

      Enter the SCORM package (player.php page) and disable CSS but keep javascript enabled, make sure the message does not appear. Disable Javascript in the browser and make sure the message does appear.

      Show
      While viewing SCORM entry page (view.php) disable the CSS but keep JavaScript enabled and check to make sure the message "JavaScript is required to view this object, please enable JavaScript in your browser and try again." does not appear on the page. Disable Javascript and make sure the message does appear. Enter the SCORM package (player.php page) and disable CSS but keep javascript enabled, make sure the message does not appear. Disable Javascript in the browser and make sure the message does appear.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      master_MDL-58863

      Description

      In https://github.com/moodle/moodle/blob/master/mod/scorm/player.php#L269 we can see that the scorm player generate a div block with the class "forcejavascriptmessage" instead of using a <noscript> tag that essentialy do the same thing.

      This came to my view after an accessibility audit we had.

       

        Attachments

          Activity

            People

            Assignee:
            danmarsden Dan Marsden
            Reporter:
            tazoeur Guillaume Latour
            Peer reviewer:
            Simey Lameze
            Integrator:
            David Monllaó
            Tester:
            Marina Glancy
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/17