Loading...

XML

Word

Printable

Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Fixed Branches:
MOODLE_34_STABLE
Pull from Repository:
https://github.com/danmarsden/moodle
Pull Main Branch:
master_~~MDL-58863~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...danmarsden:master_MDL-58863
Testing Instructions:

Hide

While viewing SCORM entry page (view.php) disable the CSS but keep JavaScript enabled and check to make sure the message "JavaScript is required to view this object, please enable JavaScript in your browser and try again." does not appear on the page.
Disable Javascript and make sure the message does appear.

Enter the SCORM package (player.php page) and disable CSS but keep javascript enabled, make sure the message does not appear. Disable Javascript in the browser and make sure the message does appear.

Show
While viewing SCORM entry page (view.php) disable the CSS but keep JavaScript enabled and check to make sure the message "JavaScript is required to view this object, please enable JavaScript in your browser and try again." does not appear on the page. Disable Javascript and make sure the message does appear. Enter the SCORM package (player.php page) and disable CSS but keep javascript enabled, make sure the message does not appear. Disable Javascript in the browser and make sure the message does appear.

In https://github.com/moodle/moodle/blob/master/mod/scorm/player.php#L269 we can see that the scorm player generate a div block with the class "forcejavascriptmessage" instead of using a <noscript> tag that essentialy do the same thing.

This came to my view after an accessibility audit we had.

Participants:: CiBoT, Dan Marsden, Dan Poltawski, David Monllaó, Guillaume Latour, Marina Glancy, Matteo Scaramuccia, Simey Lameze, Suresh Adhi