Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58898

Removing OAuth2 service does not remove linked accounts

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.3
    • Component/s: Authentication
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Setup OAuth2 service with login enabled
      2. Login to an account
      3. Go to preferences
      4. Go to linked logins
      5. Link an oauth account
      6. Delete the OAuth2 service
      7. View the Linked logins page for the user you were linking
      8. Nothing should be shown - the table should be empty
      Show
      Setup OAuth2 service with login enabled Login to an account Go to preferences Go to linked logins Link an oauth account Delete the OAuth2 service View the Linked logins page for the user you were linking Nothing should be shown - the table should be empty
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58898-master
    • Pull Master Diff URL:

      Description

      1. Setup OAuth2 service with login enabled
      2. View the login page and start the process to link an account - no need to confirm the e-mail
      3. Delete the OAuth2 service
      4. View the Linked logins page for the user you were linking
      Expected

      Nothing shown - the list should be present, but empty.

      Actual

      Stacktrace + boom because the table tries to fetch the details for the Persistent relating to that issuer

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-58774 Same email address used to create a auth_oauth user and linked to another user moodle's account produce a Error: mdb->get_record() found more than one record

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-58910 Add events and observers to OAuth Issuers

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              johno John Okely
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Andrew Nicols
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/17