Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58900

Possible to create two assign overrides with the same sortorder

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.3
    • Fix Version/s: 3.2.4, 3.3.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Note: on 3.2 there won't be a priority column on the event table, so don't worry about checking this one 3.2

      1. Create a course with two groups (no need to put users in them), we'll refer to them as A and B
      2. Create an assignment with just a due date
      3. Create a group override for group A for the due date
      4. Create a group override for group B with the same due date as before
      5. Create another override for group A with the same due date
      6. Notice that on the assign group overrides page show an up arrow and down arrow in the correct orientation (i.e. the bottom entry can only move up and vice versa)
      7. Check the 'event' table and confirm the priority for the group override matches the order on the page, where the first (top) entry should be 1, the second 2 and so on.
      8. Check the 'assign_overrides' table and confirm the sortorder matches the order shown on the page, where the first (top) entry should be 1, the second 2, and so on.
      9. Try changing the ordering and confirming the assign_override and event table columns (sortorder and priority) are updated correctly.
      Show
      Note: on 3.2 there won't be a priority column on the event table, so don't worry about checking this one 3.2 Create a course with two groups (no need to put users in them), we'll refer to them as A and B Create an assignment with just a due date Create a group override for group A for the due date Create a group override for group B with the same due date as before Create another override for group A with the same due date Notice that on the assign group overrides page show an up arrow and down arrow in the correct orientation (i.e. the bottom entry can only move up and vice versa) Check the 'event' table and confirm the priority for the group override matches the order on the page, where the first (top) entry should be 1, the second 2 and so on. Check the 'assign_overrides' table and confirm the sortorder matches the order shown on the page, where the first (top) entry should be 1, the second 2, and so on. Try changing the ordering and confirming the assign_override and event table columns (sortorder and priority) are updated correctly.
    • Workaround:
      Hide

      Click the up arrow on the top override, the sortorder will fix itself, but A will be down the bottom. Click the up arrow on A again to get it back to the top.

      Show
      Click the up arrow on the top override, the sortorder will fix itself, but A will be down the bottom. Click the up arrow on A again to get it back to the top.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58900-master

      Description

      1. Create a course with two groups (no need to put users in them), we'll refer to them as A and B
      2. Create an assignment with just a due date
      3. Create a group override for group A for the due date
      4. Create a group override for group B with the same due date as before
      5. Create another override for group A with the same due date
      6. Notice that on the assign group overrides page both of the overrides show an up arrow (the top one is supposed to be a down arrow)
      7. If you inspect the assign_overrides table you'll see both overrides have sortorder "2" (A is meant to be 1 and B is meant to be 2)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              cameron1729 cameron1729
              Integrator:
              Jake Dallimore
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17