Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58905

Disable auth_oauth2 funtionalities if the plugin is not enabled or it does not have services that allow users to login

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. Disable OAuth 2 authentication plugin if it is enabled.
      2. Log in as an admin and set up and configure the OAuth 2 Google service with a client ID and secret, as described in the documentation OAuth2 Services and OAuth 2 Google service.
      3. Go to your preferences page, there shouldn't be any "Linked logins" link
      4. Try to access auth/oauth2/linkedlogins.php, you should see a message saying that oauth2 plugin is disabled
      5. Enable the OAuth 2 authentication plugin.
      6. Go to your preferences page, there should be a link to "Linked logins", follow it, you should see the link logins page
      7. Go through all the process to link an account and check that everything is ok
      8. Go to admin/tool/oauth2/issuers.php and disable your OAuth2 Google service logins
      9. Go to your preferences page, there should be a "Linked logins" link
      10. Once you click on it you are redirected back to your preferences page with a message stating that none of the current services allow you to link an account

      Test 2

      1. Go to admin/tool/oauth2/issuers.php and enable your OAuth2 Google service logins
      2. Remove the linked account you set up
      3. Log out and try to log in with a Google account using the "Log in using your account on Google" button on the login page.
      4. Check that you see a message saying that a confirmation email has been sent.
      5. Log in as admin and disable OAuth 2 authentication plugin, log out once done
      6. Check you email and follow the link in the confirmation email (couple of steps above)
      7. You should see a plugin disabled error
      8. Login as admin and enable the plugin, log out once enabled
      9. Check you email again and follow the link in the confirmation email.
      10. Check that an account is created
      Show
      Test 1 Disable OAuth 2 authentication plugin if it is enabled. Log in as an admin and set up and configure the OAuth 2 Google service with a client ID and secret, as described in the documentation OAuth2 Services and OAuth 2 Google service. Go to your preferences page, there shouldn't be any "Linked logins" link Try to access auth/oauth2/linkedlogins.php, you should see a message saying that oauth2 plugin is disabled Enable the OAuth 2 authentication plugin. Go to your preferences page, there should be a link to "Linked logins", follow it, you should see the link logins page Go through all the process to link an account and check that everything is ok Go to admin/tool/oauth2/issuers.php and disable your OAuth2 Google service logins Go to your preferences page, there should be a "Linked logins" link Once you click on it you are redirected back to your preferences page with a message stating that none of the current services allow you to link an account Test 2 Go to admin/tool/oauth2/issuers.php and enable your OAuth2 Google service logins Remove the linked account you set up Log out and try to log in with a Google account using the "Log in using your account on Google" button on the login page. Check that you see a message saying that a confirmation email has been sent. Log in as admin and disable OAuth 2 authentication plugin, log out once done Check you email and follow the link in the confirmation email (couple of steps above) You should see a plugin disabled error Login as admin and enable the plugin, log out once enabled Check you email again and follow the link in the confirmation email. Check that an account is created
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58905_master

      Description

      A user's preferences page includes a 'Linked logins' link auth/oauth2/linkedlogins.php even when the OAuth 2 authentication plugin is disabled. This is confusing for users.

       

        Attachments

        1. linked logins.png
          linked logins.png
          15 kB
        2. screenshot-1.png
          screenshot-1.png
          20 kB
        3. screenshot-2.png
          screenshot-2.png
          16 kB
        4. screenshot-3.png
          screenshot-3.png
          31 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/17