Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58908

OAuth will overwrite gravatar image with default oauth picture.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3, 3.3 regressions
    • Fix Version/s: 3.3.1
    • Component/s: Authentication
    • Labels:
    • Testing Instructions:
      Hide

      For this test use an email address for the moodle account with a gravatar image associated, and an oauth account with a different profile picture set so you can distinguish them.

      Link a login (with a picture) to your moodle account

      make sure gravatar is disabled

      login with oauth

      verify your picture is update to the one from oauth

      enable gravar and delete your profile picture

      verify the gravatar picture is shown

      login with oauth

      verify the gravatar picture is still shown, not the oauth one

      Show
      For this test use an email address for the moodle account with a gravatar image associated, and an oauth account with a different profile picture set so you can distinguish them. Link a login (with a picture) to your moodle account make sure gravatar is disabled login with oauth verify your picture is update to the one from oauth enable gravar and delete your profile picture verify the gravatar picture is shown login with oauth verify the gravatar picture is still shown, not the oauth one
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58908-master

      Description

      Gravatar works by generating a gravatar url for the users profile picture when no picture is set in Moodle.

      OAuth works by setting a profile picture in Moodle when it is not already set.

      So logging in with oauth on a site with gravatar enabled will overwrite the gravatar image with the one from OAuth.

      This is not terrible, but sometimes when the OAuth picture is not set, the OAuth provider will return a default picture - and Moodle will set the users profile picture to that (we cannot distinguish). In this case it will appear that the gravatar image will get overwritten with a generic default one.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Marcus Green
              Integrator:
              Jun Pataleta
              Tester:
              David Mudrák (@mudrd8mz)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17