Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58966

"Expected completion for [..]" string is too long

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable completion on your site.
      2. Create a course and enable completion.
      3. Enrol a student in this course.
      4. Add a page resource to the course, setting set the activity to be marked as completed automatically and set a 'Expect completed on' date in the future
      5. Login as student
      6. VERIFY: the event in dashboard view will say '[activityname] should be completed.'

      [NOTE: existing events won't be affected by this change]

      Show
      Enable completion on your site. Create a course and enable completion. Enrol a student in this course. Add a page resource to the course, setting set the activity to be marked as completed automatically and set a 'Expect completed on' date in the future Login as student VERIFY: the event in dashboard view will say ' [activityname] should be completed.' [NOTE: existing events won't be affected by this change]
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58966-master
    • Pull Master Diff URL:

      Description

      The problem is both that its long, but also the most crucial part of the string is at the end and often gets truncated. The activity name is going to long in itself. It's also quite a robotic looking string.

       

        Attachments

          Activity

            People

            Assignee:
            poltawski Dan Poltawski
            Reporter:
            poltawski Dan Poltawski
            Peer reviewer:
            Ankit Agarwal Ankit Agarwal
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Mark Nelson Mark Nelson
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), David Mudrák (@mudrd8mz), Helen Foster, Víctor Déniz Falcón
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17