Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58985

Access conditions displayed in potentially big blue bubbles

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. In a course, prepare couple of activities with different kinds of restricted access:
        • Hidden from students
        • Stealth
        • Having (ideally a bit more complex) set of access conditions
      2. In the same course, hide a section and set up set of access conditions for another section
      3. TEST: Check the course page in standard themes, hidden sections, hidden activities and stealth activities should continue displaying the same.
      4. TEST: For restricted sections and activities, make sure the label "Restricted" is displayed followed by restriction details.
      Show
      In a course, prepare couple of activities with different kinds of restricted access: Hidden from students Stealth Having (ideally a bit more complex) set of access conditions In the same course, hide a section and set up set of access conditions for another section TEST: Check the course page in standard themes, hidden sections, hidden activities and stealth activities should continue displaying the same. TEST: For restricted sections and activities, make sure the label "Restricted" is displayed followed by restriction details.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-58985-master-bluebubbles
    • Sprint:
      3.4 Sprint 1

      Description

      This is a regression of MDL-4782 where we introduced a new mustache template for displaying status of the activity module such as "Hidden from students" or "Available but not shown on course page" in blue bootstrap labels.

      The problem is that the same template is used for displaying access conditions, too. Which may eventually be quite big (see attached screenshot from learn.moodle.net site) and it does not really look good (bootstrap labels are designed for labels, not block of texts).

      There seems to be no easy way to extract only the first line like "Not available unless:" and use it as a label as the renderer already receives the whole HTML formatted text from the underlying API.

        Attachments

        1. screenshot-3-suggested.png
          screenshot-3-suggested.png
          52 kB
        2. screenshot-2-moodle33.png
          screenshot-2-moodle33.png
          47 kB
        3. screenshot-1-moodle32.png
          screenshot-1-moodle32.png
          24 kB
        4. restrictionformat.png
          restrictionformat.png
          30 kB
        5. boostactivityrestrictions.png
          boostactivityrestrictions.png
          112 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Jul/17