Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59014

Double escaped link in calendar block

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.3.1
    • Component/s: Blocks, Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Make sure that $CFG->slasharguments is turned off.
      2. Create a calendar user event.
      3. Go to your dashboard and look for the event you created on the calendar block.
      4. Inspect the href parameter of the event's link.
        • Confirm that the ampersands are not escaped. It should look something like

          href="http://[yourmoodlesiteurl]/calendar/view.php?course=2&view=day&time=1495555200#event_2"
          

      5. Click on the event link.
      6. Check the URL of the browser window.
        • Confirm that the ampersands are not escaped. It should look something like

          href="http://[yourmoodlesiteurl]/calendar/view.php?course=2&view=day&time=1495555200#event_2"
          

      7. Go back to the dashboard.
      8. Hover on the event link.
      9. When the popover comes up, click on the link for the event on the popover.
      10. Check the URL of the browser window.
        • Confirm that the ampersands are not escaped. It should look something like

          href="http://[yourmoodlesiteurl]/calendar/view.php?course=2&view=day&time=1495555200#event_2"
          

      Show
      Make sure that $CFG->slasharguments is turned off. Create a calendar user event. Go to your dashboard and look for the event you created on the calendar block. Inspect the href parameter of the event's link. Confirm that the ampersands are not escaped. It should look something like href="http://[yourmoodlesiteurl]/calendar/view.php?course=2&view=day&time=1495555200#event_2" Click on the event link. Check the URL of the browser window. Confirm that the ampersands are not escaped. It should look something like href="http://[yourmoodlesiteurl]/calendar/view.php?course=2&view=day&time=1495555200#event_2" Go back to the dashboard. Hover on the event link. When the popover comes up, click on the link for the event on the popover. Check the URL of the browser window. Confirm that the ampersands are not escaped. It should look something like href="http://[yourmoodlesiteurl]/calendar/view.php?course=2&view=day&time=1495555200#event_2"
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59014-master

      Description

      Seems like a regression from 3.3

      I was using clean theme.

      An event in calendar block has a link of the following format which is incorrect -

      http://localhost/stable_master/calendar/view.php?view=day&time=1503945000#event_40

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              ankit_frenz Ankit Agarwal
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Dan Poltawski
              Tester:
              Marina Glancy
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17