Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59037

Fake blocks class changed from .block_fake to .block__fake in 3.2

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: HTML and CSS, Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_32_STABLE

      Description

      The new renderer override and template used for Boost changes the classname of fake blocks from .fake_block to .fake__block (with a second underscore).

      It does this as it ignores the class set by the old code and builds the class in the template from

      block_{{{type}}}

      and "type" in this case is "_fake".

      This broke my theme CSS that targetted fake blocks, though I couldn't find any core CSS that relied on this class.

      I did find one bit of core JS that seems to expect that class though:

      lib/yui/src/blocks/js/manager.js
      103:                invalid: '.block-hider-hide, .block-hider-show, .moveto, .block_fake',

      It seems like it's intended to stop drag handles being put on fake blocks.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              bawjaws David Scotson
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated: