Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59048

User tours can appear as white-on-white text

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.3
    • Fix Version/s: 3.2.4, 3.3.1
    • Component/s: User Tours
    • Labels:
    • Testing Instructions:
      Hide

      From Dan: Lets just focus on checking for regressions, unless you are particularly keen to try and find a way to reproduce the original issue, to ensure that we've not introduced regressions is enough.

      Steps to reproduce: (Ryan could not reproduce this. I originally found this in a custom OU theme, and it was easy to reproduce there. I am sure this worked for me when I submitted this issue for peer review some weeks ago.).

      1. Ensure you are using Clean theme.
      2. Make a post in Site news with HTML souce '<p class="bugdemo" style="color: white; background-color: black;">White on dark</p>' (of, if you use a custom theme, find any content where the text-colour is white.
        1. You may need to enable it: site administration > front page > front page settings - add "Announcements" as one of the "Front page items when logged in"
      3. Create a user tour, with a step targetting the .bugdemo CSS selector.
      4. View the user tour.
      5. Ceck that you can read the text in the tour pop-up.
      Show
      From Dan: Lets just focus on checking for regressions, unless you are particularly keen to try and find a way to reproduce the original issue, to ensure that we've not introduced regressions is enough. Steps to reproduce: (Ryan could not reproduce this. I originally found this in a custom OU theme, and it was easy to reproduce there. I am sure this worked for me when I submitted this issue for peer review some weeks ago.). Ensure you are using Clean theme. Make a post in Site news with HTML souce '<p class="bugdemo" style="color: white; background-color: black;">White on dark</p>' (of, if you use a custom theme, find any content where the text-colour is white. You may need to enable it: site administration > front page > front page settings - add "Announcements" as one of the "Front page items when logged in" Create a user tour, with a step targetting the .bugdemo CSS selector. View the user tour. Ceck that you can read the text in the tour pop-up.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Steps to reproduce:

      1. Ensure you are using Clean theme.
      2. Make a post in Site news with HTML souce '<p class="bugdemo" style="color: white; background-color: black;">White on dark</p>' (of, if you use a custom theme, find any content where the text-colour is white.
      3. Create a user tour, with a step targetting the .bugdemo CSS selector.
      4. View the user tour.

      Expected result: you can read the instructions.

      Actual result: the tour appear white-on-white.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Ryan Wyllie
            Integrator:
            Dan Poltawski
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17