Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59055

Manual grade item showing wrong value

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2.5, 3.3.2
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      1. Set $CFG->grade_report_user_showtotalsifcontainhidden to "Show totals excluding hidden items"
      2. Create a quiz with an end date in the future showing grade only after quiz end date
      3. As a student attempt the quiz
      4. As a teacher create a calculated item in the gradebook that is some function of the quiz grade
      5. View user report as yourself and as a student, the calculated item should display correctly
      Show
      Set $CFG->grade_report_user_showtotalsifcontainhidden to "Show totals excluding hidden items" Create a quiz with an end date in the future showing grade only after quiz end date As a student attempt the quiz As a teacher create a calculated item in the gradebook that is some function of the quiz grade View user report as yourself and as a student, the calculated item should display correctly
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      wip-MDL-59055-master

      Description

      Course with some quiz, showing the grade only after quiz ends date.
      A manual grade item containing a calculation formula averaging these quizzes.
      When there is a hidden note, and in the system configuration of user's notes report it is defined that you should not count the hidden note, in this report, when the user's view (student) is presented, the row number is displayed instead of the Calculated average. (Seeing the HTML code we got this:

      <th id = "row_13554_5550" class = "level2 leveleven item b1b column-itemname"> .. </ th>
      <td headers = "cat_4000_5550 row_13554_5550 grid" class = "level2 leveleven item b1b itemcenter column-grid" id = "yui ..."> 13554,00 </ td>
      ...
      https://www.screencast.com/t/spakAQZX )

      ( other case show the gradebook, not the html code: https://www.screencast.com/t/62ltre9Mk )
      If we change to the teacher's view, the correct average is displayed, even with the hidden notes not counted.

      ( https://www.screencast.com/t/wz5o5N5aH )

        Attachments

        1. 0001-BEHAT.patch
          1 kB
        2. 2017-05-22_1553.png
          2017-05-22_1553.png
          32 kB
        3. 2017-05-25_1149.png
          2017-05-25_1149.png
          35 kB
        4. 2017-05-25_1150.png
          2017-05-25_1150.png
          44 kB
        5. cool_behat_test.png
          cool_behat_test.png
          48 kB
        6. FIX-MDL-59055.patch
          0.7 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Sep/17