Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59076

Exceptions thrown by restore_format_weeks_plugin.class

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.3, 3.3 regressions
    • 3.3.1
    • Backup
    • MOODLE_33_STABLE
    • MOODLE_33_STABLE
    • MDL-59076_master
    • Hide
      Test 1
      1. Visit a Moodle 3.1 site.
      2. Create a course using the weekly format.
      3. Backup the course.
      4. Visit a Moodle 3.3 site.
      5. Ensure debugging is turned on.
      6. Restore the course in Moodle 3.3 and ensure there is no PHP error in your apache log.
      7. Confirm the setting 'Calculate the end date from the number of sections' for the restored course is enabled.
      Test 2
      1. Log in as an admin on a Moodle 3.2 site.
      2. Create a course (C1) using the weekly format and set the end date to sometime in the future (make a mental note of it).
      3. Create a course (C2) using the weekly format that has no end date (disable the end date field).
      4. Backup both courses.
      5. Restore the courses on a Moodle 3.3 site.
      6. Edit the course C1 and confirm the setting 'Calculate the end date from the number of sections' is disabled and the end date is accurate.
      7. Edit the course C2 and confirm the setting 'Calculate the end date from the number of sections' is enabled.
      Show
      Test 1 Visit a Moodle 3.1 site. Create a course using the weekly format. Backup the course. Visit a Moodle 3.3 site. Ensure debugging is turned on. Restore the course in Moodle 3.3 and ensure there is no PHP error in your apache log. Confirm the setting 'Calculate the end date from the number of sections' for the restored course is enabled. Test 2 Log in as an admin on a Moodle 3.2 site. Create a course (C1) using the weekly format and set the end date to sometime in the future (make a mental note of it). Create a course (C2) using the weekly format that has no end date (disable the end date field). Backup both courses. Restore the courses on a Moodle 3.3 site. Edit the course C1 and confirm the setting 'Calculate the end date from the number of sections' is disabled and the end date is accurate. Edit the course C2 and confirm the setting 'Calculate the end date from the number of sections' is enabled.

    Description

      When restoring a course backed up by a previous version of Moodle, Moodle 3.3 throws exceptions in the file restore_format_weeks_plugin.class.php due to the absence of a course end date in the backup file. The exceptions aren't displayed in the web page but appear in the apache error log file.

      Steps to repeat:

      1. In Moodle 3.3, as an administrator, restore a course backup created in a previous version of Moodle (3.0 or 3.1 are known to fail - I'm not sure about 3.2).
      2. Check the apache error log.

      The full error traceback is the following (as generated by running the phpunit tests in the CodeRunner plugin, qtype_coderunner_restore_testcase::test_restore)

      Undefined index: enddate

      /var/www/html/moodle/course/format/weeks/backup/moodle2/restore_format_weeks_plugin.class.php:166
      /var/www/html/moodle/backup/moodle2/restore_plugin.class.php:101
      /var/www/html/moodle/backup/util/plan/restore_structure_step.class.php:446
      /var/www/html/moodle/backup/util/plan/restore_task.class.php:106
      /var/www/html/moodle/backup/util/plan/restore_plan.class.php:204
      /var/www/html/moodle/backup/moodle2/restore_final_task.class.php:121
      /var/www/html/moodle/backup/moodle2/restore_stepslib.php:821
      /var/www/html/moodle/backup/util/plan/restore_execution_step.class.php:34
      /var/www/html/moodle/backup/util/plan/base_task.class.php:181
      /var/www/html/moodle/backup/util/plan/base_plan.class.php:178
      /var/www/html/moodle/backup/util/plan/restore_plan.class.php:167
      /var/www/html/moodle/backup/controller/restore_controller.class.php:339
      /var/www/html/moodle/question/type/coderunner/tests/restore_test.php:78
      /var/www/html/moodle/question/type/coderunner/tests/restore_test.php:105
      /var/www/html/moodle/lib/phpunit/classes/advanced_testcase.php:80

      Attachments

        Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-56251 Course in "Weeks" format can suggest the course end date automatically

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Activity

            People

              markn Mark Nelson
              trampgeek Richard Lobb
              John Okely John Okely
              Jake Dallimore Jake Dallimore
              David Monllaó David Monllaó
              Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Jul/17