Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59080

drawer.scss variables can not be overwritten by presets.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.2.4, 3.3.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Using Boost theme go to its settings page found in:
        Site administration > Appearance > Themes > Boost
      2. Select the Advanced settings tab.
      3. In the Raw initial SCSS text area add the following SCSS.
        $drawer-width: 200px;
        $drawer-padding-x: 10px;
        $drawer-padding-y: 10px;
        $drawer-offscreen-gutter: 20px;
      4. Save settings and then verify that when the navbar nav drawer button is pressed that the width of the drawer is narrower than it was.previously, and so too is the padding.
      Show
      Using Boost theme go to its settings page found in: Site administration > Appearance > Themes > Boost Select the Advanced settings tab. In the Raw initial SCSS text area add the following SCSS. $drawer-width: 200px; $drawer-padding-x: 10px; $drawer-padding-y: 10px; $drawer-offscreen-gutter: 20px; Save settings and then verify that when the navbar nav drawer button is pressed that the width of the drawer is narrower than it was.previously, and so too is the padding.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59080_master

      Description

      The following variables in drawer.scss are hard coded and can not be overwritten by presets. Unless there is a reason why those values should not be overwritten, then It would make better sense to be able to change those values in the presets.

      $drawer-width: 285px;
      $drawer-padding-x: 20px;
      $drawer-padding-y: 20px;
      $drawer-offscreen-gutter: 20px;

      Could be flexible if styles like this::

      $drawer-width: 285px !default;
      $drawer-padding-x: 20px !default;
      $drawer-padding-y: 20px !default;
      $drawer-offscreen-gutter: 20px !default;

      Original suggestion by Urs Hunkler

      https://moodle.org/mod/forum/discuss.php?d=352801

       

        Attachments

          Activity

            People

            Assignee:
            lazydaisy Mary Evans
            Reporter:
            lazydaisy Mary Evans
            Peer reviewer:
            Damyon Wiese
            Integrator:
            Dan Poltawski
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            3 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17