Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59091

The Grunt gherkinlint task does not exit with fail

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Run "grunt gherkinlint" and there should be no errors.  Use "echo $?" to confirm exit code is zero.
      2. Mess up a Behat feature file (add whitespace, mess up indentation)
      3. Run "grunt gherkinlint" and there should be errors and the task should fail.  Use "echo $?" to confirm exit code is not zero.
      Show
      Run "grunt gherkinlint" and there should be no errors.  Use "echo $?" to confirm exit code is zero. Mess up a Behat feature file (add whitespace, mess up indentation) Run "grunt gherkinlint" and there should be errors and the task should fail .  Use "echo $?" to confirm exit code is not zero.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59091_gherkinlint_fix

      Description

      At the moment, 3.3 does not pass the gherkinlint Grunt task cleanly, EG: https://integration.moodle.org/view/All/job/06.%20Run%20grunt%20and%20detect%20changes%20(master)/6353/console

       

      Running "gherkinlint" task
      /var/lib/jenkins/git_repositories/master/mod/data/tests/behat/completion_condition_entries.feature
        7      Wrong indentation for "Scenario", expected indentation level of 2, but got 0    indentation
       
      /var/lib/jenkins/git_repositories/master/mod/quiz/tests/behat/editing_remove_multiple_questions.feature
        171    Multiple empty lines are not allowed                                            no-multiple-empty-lines
      

      Seems like the task should fail, otherwise no one will notice. Currently passes in Travis CI and in moodle-plugin-ci.

        Attachments

          Activity

            People

            Assignee:
            bushido Mark Nielsen
            Reporter:
            bushido Mark Nielsen
            Peer reviewer:
            Sam Chaffee
            Integrator:
            Dan Poltawski
            Tester:
            John Okely
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17