Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59094

npm 5 causing problems with npm-shrinkwrap.json (and causing travis to fail)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.3, 3.3
    • Fix Version/s: 3.2.4, 3.3.1
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      1. Ensure travis tests pass

      Master only:

      1. Use nvm to manage multiple node/npm versions
      2. Install node versions 5 to 8 one by one and in your moodle checkout:
        1. rm -R node_modules
        2. npm install
        3. grunt
        4. VERIFY: no differences created in the codebase
      Show
      Ensure travis tests pass Master only: Use nvm to manage multiple node/npm versions Install node versions 5 to 8 one by one and in your moodle checkout: rm -R node_modules npm install grunt VERIFY: no differences created in the codebase
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59094-master

      Description

      When using npm version 5, doing npm install is causing changes to be generated in the shrinkwrap file.

      This is not expected causing our travis test with the latest version of node to fail.

      From response to my comments on https://github.com/npm/npm/issues/16728#issuecomment-305104149 I think that if generate the lockfile on npm 5, it should be BC with previous versions and stop this problem. We'll have to ensure that people updating the lockfile always use npm >5 though)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Eloy Lafuente (stronk7)
              Integrator:
              Jake Dallimore
              Tester:
              Jake Dallimore
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17