Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59094

npm 5 causing problems with npm-shrinkwrap.json (and causing travis to fail)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.2.4, 3.3.1
    • 3.2.3, 3.3
    • JavaScript
    • MOODLE_32_STABLE, MOODLE_33_STABLE
    • MOODLE_32_STABLE, MOODLE_33_STABLE
    • MDL-59094-master
    • Hide
      1. Ensure travis tests pass

      Master only:

      1. Use nvm to manage multiple node/npm versions
      2. Install node versions 5 to 8 one by one and in your moodle checkout:
        1. rm -R node_modules
        2. npm install
        3. grunt
        4. VERIFY: no differences created in the codebase
      Show
      Ensure travis tests pass Master only: Use nvm to manage multiple node/npm versions Install node versions 5 to 8 one by one and in your moodle checkout: rm -R node_modules npm install grunt VERIFY: no differences created in the codebase

      When using npm version 5, doing npm install is causing changes to be generated in the shrinkwrap file.

      This is not expected causing our travis test with the latest version of node to fail.

      From response to my comments on https://github.com/npm/npm/issues/16728#issuecomment-305104149 I think that if generate the lockfile on npm 5, it should be BC with previous versions and stop this problem. We'll have to ensure that people updating the lockfile always use npm >5 though)

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Jake Dallimore Jake Dallimore
            Jake Dallimore Jake Dallimore
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.