Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59125

nolink class is not respected by urltolink filter

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. In /admin/settings.php?section=editorsettingsatto update the Toolbar config entry for links: links = link, noautolink
      2. Enable filter "URL to link", go to its settings and check apply to HTML text
      3. Using atto text editor (e.g. adding a label to a course): type http://www.example.com into the textarea
      4. Highlight the url and click on the nolink button in the toolbar.
      5. Save your content and display
      6. The link should appear as normal text, not a hyperlink. 
      Show
      In /admin/settings.php?section=editorsettingsatto update the Toolbar config entry for links: links = link, noautolink Enable filter "URL to link", go to its settings and check apply to HTML text Using atto text editor (e.g. adding a label to a course): type http://www.example.com  into the textarea Highlight the url and click on the nolink button in the toolbar. Save your content and display The link should appear as normal text, not a hyperlink. 
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      wip-MDL-59125-master

      Description

      In atto you can add the noautolink button to the editor. This puts a span around a url with the nolink class:

      <span class="nolink">http:www.example.com</span>

      I would expect the urltolink filter to check for this class and not attempt to automatically make the link active, but it does make the link active.

        Attachments

        1. linked.jpg
          linked.jpg
          16 kB
        2. nolink.jpg
          nolink.jpg
          20 kB
        3. spannolink.jpg
          spannolink.jpg
          19 kB

          Issue Links

            Activity

              People

              Assignee:
              msharp Mark Sharp
              Reporter:
              msharp Mark Sharp
              Peer reviewer:
              Marina Glancy
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17