Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59140

Introduce an upper limit on the number of courses displayed in "courses" node in flat navigation

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Prerequisite.
      1. Create 10 courses with one enrolled student (feel free to use the attached script but there are hard-coded variables (category id, user id, role id) you may need to change).
      2. Log in as an admin.
      3. Search for 'navcourselimit' in the 'Site administration' search.
      4. Confirm the default value is set to 10.
      5. Change the value to the default value if it isn't already.
      Test 1 (Test on Boost and Clean)
      1. Log in as the student.
      2. Visit your dashboard.
      3. Confirm all the courses are shown under 'My courses' on the navigation on the left.
      4. Confirm there is not a 'More...' link at the bottom of the list.
      Test 2 (Test on Boost and Clean)
      1. Log in as an admin.
      2. Search for 'navcourselimit' in the 'Site administration' search.
      3. Change the value to 5.
      4. Log in as the student.
      5. Visit your dashboard.
      6. Confirm only 5 courses are shown under 'My courses' on the navigation on the left.
      7. Confirm there is a 'More...' link at the bottom.
      8. Confirm clicking on the 'More...' link takes you to the course/index.php page.
      Test 3 (Repeat for 3.2, 3.3 and 3.4)
      1. Create a 3.x (whatever version you are testing) site on stable.
      2. Log in as an admin.
      3. Search for 'navcourselimit' in the 'Site administration' search.
      4. Confirm this is set to 20.
      5. Upgrade to integration 3.x (whatever version you are testing).
      6. Search for 'navcourselimit' in the 'Site administration' search.
      7. Confirm the value is set to 10.
      Test 4 (Repeat for 3.2, 3.3 and 3.4)
      1. Create a 3.x (whatever version you are testing) site on stable.
      2. Log in as an admin.
      3. Search for 'navcourselimit' in the 'Site administration' search.
      4. Change this value to 25.
      5. Upgrade to integration 3.x (whatever version you are testing).
      6. Search for 'navcourselimit' in the 'Site administration' search.
      7. Confirm the value is still set to 25.
      Test 5
      1. Create 20 courses with a student enrolled.
      2. Make 4 of these courses in the past.
      3. Make 4 of these courses in the future.
      4. Log in as an admin and search for 'navcourselimit' in the 'Site administration' search, set this to 20 and stay on this page.
      5. In two other browsers log in as the same student but one using boost, the other using clean.
      6. Go to your dashboard.
      7. Check that in boost you see 12 courses with no 'More...' link in the flat navigation.
      8. Check that in clean you see 20 courses with no 'More...' link in the navigation block.
      9. In the window you had open as an admin change 'navcourselimit' to '15'.
      10. Check that in boost you see 12 courses with no 'More...' link.
      11. Check that in clean you see 15 courses with a 'More...' link.
      12. In the window you had open as an admin change 'navcourselimit' to '11'.
      13. Check that in boost you see 11 courses with a 'More...' link.
      14. Check that in clean you see 11 courses with a 'More...' link.
      Show
      Prerequisite. Create 10 courses with one enrolled student (feel free to use the attached script but there are hard-coded variables (category id, user id, role id) you may need to change). Log in as an admin. Search for 'navcourselimit' in the 'Site administration' search. Confirm the default value is set to 10. Change the value to the default value if it isn't already. Test 1 (Test on Boost and Clean) Log in as the student. Visit your dashboard. Confirm all the courses are shown under 'My courses' on the navigation on the left. Confirm there is not a 'More...' link at the bottom of the list. Test 2 (Test on Boost and Clean) Log in as an admin. Search for 'navcourselimit' in the 'Site administration' search. Change the value to 5. Log in as the student. Visit your dashboard. Confirm only 5 courses are shown under 'My courses' on the navigation on the left. Confirm there is a 'More...' link at the bottom. Confirm clicking on the 'More...' link takes you to the course/index.php page. Test 3 (Repeat for 3.2, 3.3 and 3.4) Create a 3.x (whatever version you are testing) site on stable. Log in as an admin. Search for 'navcourselimit' in the 'Site administration' search. Confirm this is set to 20. Upgrade to integration 3.x (whatever version you are testing). Search for 'navcourselimit' in the 'Site administration' search. Confirm the value is set to 10. Test 4 (Repeat for 3.2, 3.3 and 3.4) Create a 3.x (whatever version you are testing) site on stable. Log in as an admin. Search for 'navcourselimit' in the 'Site administration' search. Change this value to 25. Upgrade to integration 3.x (whatever version you are testing). Search for 'navcourselimit' in the 'Site administration' search. Confirm the value is still set to 25. Test 5 Create 20 courses with a student enrolled. Make 4 of these courses in the past. Make 4 of these courses in the future. Log in as an admin and search for 'navcourselimit' in the 'Site administration' search, set this to 20 and stay on this page. In two other browsers log in as the same student but one using boost, the other using clean. Go to your dashboard. Check that in boost you see 12 courses with no 'More...' link in the flat navigation. Check that in clean you see 20 courses with no 'More...' link in the navigation block. In the window you had open as an admin change 'navcourselimit' to '15'. Check that in boost you see 12 courses with no 'More...' link. Check that in clean you see 15 courses with a 'More...' link. In the window you had open as an admin change 'navcourselimit' to '11'. Check that in boost you see 11 courses with a 'More...' link. Check that in clean you see 11 courses with a 'More...' link.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59140_master

      Description

      This flat navigation is unusable with a large number of courses.

        Attachments

          Activity

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17