Review tool_analytics and report_insights UI / UX

This issue is changing the UI, so it is worth to pay attention to anything that does not make sense You need: course without teacher course category without courses and course category with courses suspended user Install git clone git://github.com/dmonllao/moodle-local_testanalytics local/testanalytics If you already tested analytics issues and you want to discard possible problems (existing insights when the instructions state that any insight should appear) during testing you can install a new site Go to course/index.php?categoryid=(CATEGORYWITHOUTCOURSES) and expand admin menu You SHOULD NOT see any link to "Insights" Go to admin/tool/analytics/index.php Execute "Get predictions" for "Useless categories" model You will need to disable the "onlycli" admin setting in order to see the "Get predictions" link in the action dropdown. The notification at the top of the analytics page will take you to the settings page. Go to course/index.php?categoryid=(CATEGORYWITHOUTCOURSES) You SHOULD see a link to "Insights" Go to admin/tool/analytics/index.php and disable Useless categories model You should see "Disabled model" in column "Insights" for all models with a "No" in "Enabled" column Go to course/index.php?categoryid=(CATEGORYWITHOUTCOURSES) and expand admin menu You SHOULD NOT see any link to "Insights" Go to admin/tool/analytics/index.php and enable Useless categories model Go to course/index.php?categoryid=(CATEGORYWITHOUTCOURSES) You SHOULD see a link to "Insights" Go to admin/tool/analytics/index.php Execute "Get predictions" action in the following models (enable them if they are not): "No teaching" "Binary" "Undead users" "Useless categories" Select "All predictions" in "No teaching" model You SHOULD see "No teaching" as the heading in the main region, "System" in the header and a navigation bar with "Site admininstration" > Reports > Insights Use the menu to select another insight (it should be binary example random calculation) You SHOULD see the pagination pages selector and you should be able to move between pages Click on Actions > View prediction details in one of the predictions You SHOULD see "System" in the header, the navbar SHOULD contain "Site administration" > "Reports" and "Insights" as the current page; also the main region SHOULD contain the name of the model, you SHOULD also see "Prediction details" and a new table below it containing just one element If using boost insight's "Prediction" column should be colored and the "Prediction details" table as well If using clean or more they should not be colors Switch to another theme (clean if using boost or boost if using clean) and check that colors are displayed (or not) as explain above Return to admin/tool/analytics/index.php Select one of the options in "Useless categories" model You SHOULD see the name of the category in the header, the navbar SHOULD contain the category name and "Insights" as the current page; also the main region SHOULD contain the name of the model and you SHOULD see one prediction; go to actions menu and click "View prediction details" You SHOULD see again the category name in the header and in the navbar and the insight name in a heading inside the main region of the page Return to admin/tool/analytics/index.php Select one of the options in "Undead users" model You SHOULD see the user name in the header, the navbar SHOULD contain the user name and "Insights" as the current page; also the main region SHOULD contain the name of the model and you SHOULD see one prediction; go to actions menu and click "View prediction details" You SHOULD see again the user name in the header and in the navbar and the insight name in a heading inside the main region of the page