Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59169

grade report fails to save after edit with multiple tabs

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test setup
      1. Create a course
      2. Enrol 3 users, "A", "B" and "C".
      3. Create 2 groups, "Group 1" and "Group 2".
      4. Add user A and B to group 1;
      5. Add user C to group 2.
      6. Edit the course
        1. Set the group mode to "visible groups".
      7. Go to gradebook setup and add a grade item with default settings.
      Test navigation
      1. Navigate to the gradebook of the course you created
      2. Navigate to the User report
      3. Select Group 1
      4. Select User A
      5. Open a new browser tab and navigate to the same page as the initial tab (Note: in some browsers you can do this by right-clicking on the tab, and choosing "Duplicate tab")
      6. Select Group 2 in the new tab
      7. Select User C
      8. Return to the initial tab and select User B.
        1. Confirm: User report for User B should be displayed (rather than an error reporting that the user is not a member of this group).

      Navigation test can be repeated for reports other than user report.

      Test Grading
      1. Navigate to the gradebook of the course you created
      2. Navigate to the Grader report
      3. Turn editing on.
      4. Select Group 1.
      5. Open a new tab and navigate to the same page as in the initial tab.
      6. Select Group 2 in the new tab.
      7. Return to the initial tab
      8. Edit the grade item for User A.
      9. Save changes
        1. Confirm: Changes should be saved successfully and updated grades displayed for Group 1.
      Show
      Test setup Create a course Enrol 3 users, "A", "B" and "C". Create 2 groups, "Group 1" and "Group 2". Add user A and B to group 1; Add user C to group 2. Edit the course Set the group mode to "visible groups". Go to gradebook setup and add a grade item with default settings. Test navigation Navigate to the gradebook of the course you created Navigate to the User report Select Group 1 Select User A Open a new browser tab and navigate to the same page as the initial tab (Note: in some browsers you can do this by right-clicking on the tab, and choosing "Duplicate tab") Select Group 2 in the new tab Select User C Return to the initial tab and select User B. Confirm : User report for User B should be displayed (rather than an error reporting that the user is not a member of this group). Navigation test can be repeated for reports other than user report. Test Grading Navigate to the gradebook of the course you created Navigate to the Grader report Turn editing on. Select Group 1. Open a new tab and navigate to the same page as in the initial tab. Select Group 2 in the new tab. Return to the initial tab Edit the grade item for User A. Save changes Confirm : Changes should be saved successfully and updated grades displayed for Group 1.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59169-master

      Description

      If you:

      • turn editing on
      • open a grade report for a course with groups, and select a group
      • open the same grade report in another tab, and select a different group
      • return to the first tab, and save changes

      Save fails. While this is not necessarily a data loss issue, users who don't know exactly what is going on will lose the data they have entered.

      Failure is because the page that the form submission returns to gets its list of users based on the group specified in the second tab (set via cookie rather than URL or form).

      It seems to me that grade_plugin_return objects should track group id; that would enable a fix for this, and for MDL-56482 - and I suspect simplify fixes/enhancements in many other places.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 45 minutes
                  45m