Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59230

tab_preferences AMD module does not load core/notification

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Open blocks/myoverview/amd/src/tab_preferences.js
      2. Change methodname parameter on line 41 to something else:
        methodname: 'ccore_user_update_user_preferencesssss',
      3. Go to the dashboard and change a tab on course overview block.
      4. Make sure you see a pop up with the exception.
      Test 2

      Do a sanity check on the patch.

      Show
      Test 1 Open blocks/myoverview/amd/src/tab_preferences.js Change methodname parameter on line 41 to something else: methodname: 'ccore_user_update_user_preferencesssss', Go to the dashboard and change a tab on course overview block. Make sure you see a pop up with the exception. Test 2 Do a sanity check on the patch.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59230-master

      Description

      During the testing of MDL-58907, I noticed the newly introduced AMD module tab_preferences.js is using Notification.exception here but it not loading core/notifications module here, that is prone to errors in the future.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              lameze Simey Lameze
              Peer reviewer:
              Mark Nelson
              Integrator:
              Jake Dallimore
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17