Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.3.1
Affects Version/s: 3.3, 3.4
Component/s: Dashboard (My home)
Labels:
- ci
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_33_STABLE
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Main Branch:
~~MDL-59230~~-master
Pull Main Diff URL:
https://github.com/lameze/moodle/compare/6bb80a1...MDL-59230-master
Testing Instructions:
Hide

Test 1

Open blocks/myoverview/amd/src/tab_preferences.js

Change methodname parameter on line 41 to something else:
methodname: 'ccore_user_update_user_preferencesssss',

Go to the dashboard and change a tab on course overview block.

Make sure you see a pop up with the exception.

Test 2

Do a sanity check on the patch.
Show
Test 1 Open blocks/myoverview/amd/src/tab_preferences.js Change methodname parameter on line 41 to something else: methodname: 'ccore_user_update_user_preferencesssss', Go to the dashboard and change a tab on course overview block. Make sure you see a pop up with the exception. Test 2 Do a sanity check on the patch.

Description

During the testing of ~~MDL-58907~~, I noticed the newly introduced AMD module tab_preferences.js is using Notification.exception here but it not loading core/notifications module here, that is prone to errors in the future.

Attachments

Issue Links

Discovered while testing

MDL-58907 In course overview, on some sites, the timeline is usually/always going to be empty, forcing user to do extra navigation

Closed

Activity

People

Assignee:: Simey Lameze

Reporter:: Simey Lameze

Peer reviewer:: Mark Nelson

Integrator:: Jake Dallimore

Tester:: David Monllaó

Participants:: CiBoT, David Monllaó, Jake Dallimore, Mark Nelson, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 14/Jun/17 10:28 PM

Updated:: 23/Jun/17 9:56 AM

Resolved:: 23/Jun/17 9:56 AM

Fix Release Date:: 10/Jul/17