[MDL-59263] Edit and preview icons not showing in admin/usersroles.php - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE
Fixed Branches:
MOODLE_33_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
wip-~~MDL-59263~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/4c6063bff9...wip-MDL-59263-master
Testing Instructions:
Hide

Log in as admin

Go to site admin ->Users -> Browse list of users

Click on a user name to go to user profile page (user should have any enrolments or role assignments)

Click on Preferences

Click on This user's role assignments

Make sure next to each role there are icons "edit" and "check permissions"
Show
Log in as admin Go to site admin ->Users -> Browse list of users Click on a user name to go to user profile page (user should have any enrolments or role assignments) Click on Preferences Click on This user's role assignments Make sure next to each role there are icons "edit" and "check permissions"

Wrong order of parameters in calls to pix_icon function (lines 196 and 197) prevent icons from rendering.

Steps:

is a regression caused by

MDL-40759 Use the Font Awesome icon font for all icons in Moodle

Participants:: CiBoT, David Monllaó, Eloy Lafuente (stronk7), Jake Dallimore, Jean-Roch Meurisse, Marina Glancy