Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59264

Popout-buttons added to every label in grading from

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: Assignment, Grading methods
    • Labels:
      None
    • Affected Branches:
      MOODLE_32_STABLE

      Description

      The Assignment grader interface has a feature of popping-out the form elements. These popout button links are added by some JS in mod/assignment/amd/src/grading_panel.js

                  parents.addClass('has-popout').find('label').parent().append(html);

      That JS assumes there will only be one label tag in the area it works on, when this is not true (as in the checklist grading form: https://moodle.org/plugins/gradingform_checklist) you get some extra popout icons in odd places. (Note a CSS workaround to hide the extra popups has just been added to the gradingform_checklist addon, so it no longer displays the issue)

      I think it would be possible to narrow the selectors used in this JS by adding .first() after the .find('label') and only hit the intended label in a cross-theme manner..

                  parents.addClass('has-popout').find('label').first().parent().append(html);

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              bawjaws David Scotson
              Participants:
              Component watchers:
              Damyon Wiese, Adrian Greeve, Mihail Geshoski, Peter Dias, Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: