Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59294

Login page IDP list looks ugly on clean

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.3, 3.3, 3.4
    • Fix Version/s: 3.2.4, 3.3.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Note: Test on Clean

      1. Purge caches.
      2. Log in as admin.
      3. Go to "Site administration / Advanced features" and enable "Networking".
      4. Go to "Site administration / Plugins / Authentication" and turn on "MNet authentication". On 3.3 and master, turn "OAuth 2" as well.
      5. Under "Common settings", make sure that "Self registration" is disabled.
      6. Go to "Site administration / Networking / Manage peers"
      7. Add a Mahara host:
      8. On 3.3 and master, set up one or more OAuth2 services (e.g. Facebook, Google, Microsoft)
      9. Log out.
      10. Go to login page.
      11. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master).
        • Confirm that the buttons look nice and consistent with the Clean theme.
        • Confirm that the buttons are centre-aligned just like the login button.
      12. Login as an admin
      13. Go back to "Site administration / Plugins / Authentication"
      14. Set "Self registration" to "Email-based self-registration"
      15. Log out and go back to the login page.
      16. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master).
        • Confirm that the buttons look nice and consistent with the Clean theme.
        • Confirm that the buttons are centre-aligned in the "signuppanel" div just like the "Create a new account" button.
      Login block
      1. Login as admin and go to the site home
      2. Turn editing on and add the login block.
      3. Logout and go to the site home where the login block is.
      4. Make sure you're using Boost theme.
      5. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master).
        • Confirm that the buttons look nice and consistent with the Boost theme.
      6. Switch to Clean theme.
      7. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master).
        • Confirm that the buttons look nice and consistent with the Clean theme.
      Show
      Note: Test on Clean Purge caches. Log in as admin. Go to " Site administration / Advanced features " and enable " Networking ". Go to " Site administration / Plugins / Authentication " and turn on " MNet authentication ". On 3.3 and master, turn " OAuth 2 " as well. Under " Common settings ", make sure that " Self registration " is disabled. Go to " Site administration / Networking / Manage peers " Add a Mahara host: Hostname: https://demo.mahara.org Application type: mahara In the services tab, check all boxes. On 3.3 and master, set up one or more OAuth2 services (e.g. Facebook, Google, Microsoft) Log out. Go to login page. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master). Confirm that the buttons look nice and consistent with the Clean theme. Confirm that the buttons are centre-aligned just like the login button. Login as an admin Go back to " Site administration / Plugins / Authentication " Set " Self registration " to " Email-based self-registration " Log out and go back to the login page. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master). Confirm that the buttons look nice and consistent with the Clean theme. Confirm that the buttons are centre-aligned in the " signuppanel " div just like the " Create a new account " button. Login block Login as admin and go to the site home Turn editing on and add the login block. Logout and go to the site home where the login block is. Make sure you're using Boost theme. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master). Confirm that the buttons look nice and consistent with the Boost theme. Switch to Clean theme. Check the Mahara login button and the OAuth2 login buttons (if on 3.3 and master). Confirm that the buttons look nice and consistent with the Clean theme.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59294-master

      Description

      I have noticed the IDP list on the login page using clean theme looks ugly.

      We should try to let it as close to boost we can.

        Attachments

        1. better now.png
          39 kB
          Simey Lameze
        2. buttons.png
          11 kB
          Simey Lameze
        3. capture-for-jira-screenshot-20170705-172251-418.png
          56 kB
          Ankit Agarwal
        4. capture-for-jira-screenshot-20170705-172345-072.png
          73 kB
          Ankit Agarwal
        5. idp list clean nice.png
          46 kB
          Simey Lameze
        6. idp list clean ugly.png
          47 kB
          Simey Lameze
        7. self-reg-disabled.png
          78 kB
          Jun Pataleta
        8. site home with login block enabled.png
          112 kB
          Simey Lameze
        9. site home with login block enabled.png
          111 kB
          Simey Lameze

          Activity

            People

            • Assignee:
              jpataleta Jun Pataleta
              Reporter:
              lameze Simey Lameze
              Peer reviewer:
              Simey Lameze
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17