Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59299

Use new filetypes form element for assignment file types

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to admin settings for assignment file submission
      2. Confirm that the 'Default accepted file types' is using the new element with the text field and button
      3. Using the button, add the entire 'documents files' group, and expand 'Image files' and select 'BMP' and 'GIF' only
      4. Save the form and confirm the text field and type summary below the field have both been updated.
      5. Now, in a course, click to create a new assignment
      6. Confirm that the 'accepted file types' (under the 'submission types' fieldset heading) is using the new element too
      7. Confirm also that this field has a preset value of 'document,.bmp,.gif'
      8. Create the assignment and edit it's settings
      9. Confirm that the value is still 'document,.bmp,.gif'
      10. Change this value to something new, using either the button + modal, or the text field directly. Save.
      11. Edit again and confirm that the new values are listed.
      12. Now remove the value from the text field and save again.
      13. Edit again and confirm that the new value is now empty.
      14. (Regression test) Set to pdf documents only and confirm as a student that you can't attach a doc file.
      15. Make sure it shows the correct file types you selected underneath the file picker
      16. Set the accepted types to none by unticking all the selected types
      17. Make sure you can submit any file type
      18. Go to another file manager (e.g. private files)
      19. Make sure you don't see the message below the file picker element, since it allows any file type
      20. Go to Site administration > Plugins > Install plugins
      21. Make sure you see "Accepted types: Zip" and no visual problems
      Show
      Go to admin settings for assignment file submission Confirm that the 'Default accepted file types' is using the new element with the text field and button Using the button, add the entire 'documents files' group, and expand 'Image files' and select 'BMP' and 'GIF' only Save the form and confirm the text field and type summary below the field have both been updated. Now, in a course, click to create a new assignment Confirm that the 'accepted file types' (under the 'submission types' fieldset heading) is using the new element too Confirm also that this field has a preset value of 'document,.bmp,.gif' Create the assignment and edit it's settings Confirm that the value is still 'document,.bmp,.gif' Change this value to something new, using either the button + modal, or the text field directly. Save. Edit again and confirm that the new values are listed. Now remove the value from the text field and save again. Edit again and confirm that the new value is now empty. (Regression test) Set to pdf documents only and confirm as a student that you can't attach a doc file. Make sure it shows the correct file types you selected underneath the file picker Set the accepted types to none by unticking all the selected types Make sure you can submit any file type Go to another file manager (e.g. private files) Make sure you don't see the message below the file picker element, since it allows any file type Go to Site administration > Plugins > Install plugins Make sure you see "Accepted types: Zip" and no visual problems
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59299-master
    • Sprint:
      3.4 Sprint 2, 3.4 Sprint 3

      Description

      form element was introduced in MDL-53240

      File type restrictions for mod_assign (introduced in MDL-39913) should use new form element

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17