Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59311

When duplicating module the course cache is rebuilt twice

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Duplicate last module in a section
      2. Refresh course page and make sure the duplicated module is still in the correct position
      3. Duplicate another module (not the last one)
      4. Refresh course page and make sure the duplicated module is right below the original module

      If you want to test performance win:

      1. Create a course with many modules
      2. Open course page in editing mode
      3. Add 'logall' => 1 to the $CFG->dboptions in the config.php
      4. Duplicate a module
      5. Count the number of new records in mdl_log_queries table
      6. Revert the commit
      7. Duplicate a module
      8. Count the number of new records in mdl_log_queries table - it is much larger (the bigger the course the larger is the difference)
      9. Remove 'logall'
      Show
      Duplicate last module in a section Refresh course page and make sure the duplicated module is still in the correct position Duplicate another module (not the last one) Refresh course page and make sure the duplicated module is right below the original module If you want to test performance win: Create a course with many modules Open course page in editing mode Add 'logall' => 1 to the $CFG->dboptions in the config.php Duplicate a module Count the number of new records in mdl_log_queries table Revert the commit Duplicate a module Count the number of new records in mdl_log_queries table - it is much larger (the bigger the course the larger is the difference) Remove 'logall'
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-59311-master
    • Pull Master Diff URL:

      Description

      Noticed while looking at MDL-59300 - that's a performance problem. Rebuilding course cache on large courses can take long time.

        Attachments

          Issue Links

          Discovered while testing

          New Feature - A new Moodle feature which has yet to be developed. MDL-59300 Duplicated activity should have a suffix added to the name

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              • Assignee:
                marina Marina Glancy
                Reporter:
                marina Marina Glancy
                Peer reviewer:
                Mark Nelson
                Integrator:
                David Monllaó
                Tester:
                Simey Lameze
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Matteo Scaramuccia, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Sep/17