[MDL-59362] Missing 'new' keyword when throwing exceptions - Moodle Tracker

XML

Word

Printable

Testing Instructions:
1. Confirm there are no places in core where we are throwing a coding_exception, or moodle_exception without using new.
Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Pull from Repository:
git://github.com/markn86/moodle.git
Pull Master Branch:
~~MDL-59362~~_master
Pull Master Diff URL:
https://github.com/markn86/moodle/compare/master...MDL-59362_master

Do a grep throughout the Moodle core and confirm there are no cases where we are calling
throw (\)coding_exception
without using the new keyword.

I discovered this when reviewing the analytics code and wondered if perhaps this was copied from other places in core and found a few.

has a non-specific relationship to

MDL-30409 'throw coding_exception' (missing new) in moodlelib