Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59377

Activity "Display description on course page" omits description images when activity is restricted

    XMLWordPrintable

    Details

    • Database:
      MySQL
    • Testing Instructions:
      Hide
      1. As teacher create some module in the course, tick "Show description" and add images to the description
      2. Set the access restriction for this module so the students do not satisfy it (for example, set the date in the future)
      3. Create a label with images and access restriction
      4. Use another browser as a student, go to the course page and make sure you can see images (but there is no link to the module). Open image URL in a separate window and hit refresh to double check, leave them open
      5. As a teacher edit both modules and change "access restriction" closing the eye (which means hidden unless available)
      6. As a student you should no longer be able to see description of the first module and the label on the course page. Make sure the images in separate windows do not display.
      7. As a teacher "open the eye" for access restriction for the first module but untick "Show description"
      8. Again, student should not be able to view the image embedded in the description by accessing the URL directly
      Show
      As teacher create some module in the course, tick "Show description" and add images to the description Set the access restriction for this module so the students do not satisfy it (for example, set the date in the future) Create a label with images and access restriction Use another browser as a student, go to the course page and make sure you can see images (but there is no link to the module). Open image URL in a separate window and hit refresh to double check, leave them open As a teacher edit both modules and change "access restriction" closing the eye (which means hidden unless available) As a student you should no longer be able to see description of the first module and the label on the course page. Make sure the images in separate windows do not display. As a teacher "open the eye" for access restriction for the first module but untick "Show description" Again, student should not be able to view the image embedded in the description by accessing the URL directly
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      wip-MDL-59377-master-3

      Description

      To reproduce:

      • in a course, create two activities.
      • for both activities, add a description containg text and at least one image
      • make sure "Display description on course page" is checked for both activities
      • save and return to course.
      • access the course using an account which has student role in the above course (make sure you are NOT working with "login as")
      • text and images are displayed correctly in the course home page for both activities
      • now login using an account with editing capability, edit course first activity and add a completion criteria
      • edit second activity and add a access restriction based on completion of previous activity
      • make sure the second activity is NOT hidden by the restriction
      • login again using an account which has student role in the above course (make sure you are NOT working with "login as")
      • image description of the second activity is broken, while text is visible

       Versions 3.1 LTS and 3.3 latest builds seem both affected (see attached screenshot taken from a 3.3)

       

       

        Attachments

          Activity

            People

            • Assignee:
              marina Marina Glancy
              Reporter:
              andreabix Andrea Bicciolo
              Peer reviewer:
              Ryan Wyllie
              Integrator:
              David Monllaó
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Sam Marshall, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Matteo Scaramuccia, Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Sep/17