Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59380

Fragments API does not return javascript from a mustache template

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.2.4, 3.3.1
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Apply the testing commit (patch file attached).

      Verify on the notification preferences page (open the bell menu and click the cog) you see an alert when the page loads AND every time you open the email settings modal.

       

      Show
      Apply the testing commit (patch file attached). Verify on the notification preferences page (open the bell menu and click the cog) you see an alert when the page loads AND every time you open the email settings modal.  
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59380-master

      Description

      The fragments API is supposed to return all HTML and JS generated while rendering into 2 variables as it's response. It misses the JS added from the mustache javascript helper because the javascript mustache helper holds a direct reference to the wrong page requirements manager.

       

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Simey Lameze
              Integrator:
              Jake Dallimore
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17