Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59399

collapsible items in atto insertmedia don't work in assignments

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Make sure your site has the developer debug messages enable (mdk run dev if you're using mdk)
      2. Log in as admin
      3. Create a course
      4. Enrol a user in the course as a student
      5. Add an assignment to activity to the course and make sure the "online text" option is checked for allowed submission types
      6. Log in as the student
      7. Go to the assignment and click to add a submission
      8. Open the browser console
      9. In the "online text" section of the submission form click on the media button (looks like a film camera) in the editor toolbar
      10. Confirm that the M.form.shortforms is not a function error is not reported in the browser console
      11. Click the "video" tab in the insert media modal
      12. Confirm that each of the collapsible regions (Display options, Advanced settings, Subtitles and captions) in the short form can be expanded and collapsed
      Show
      Make sure your site has the developer debug messages enable ( mdk run dev if you're using mdk) Log in as admin Create a course Enrol a user in the course as a student Add an assignment to activity to the course and make sure the "online text" option is checked for allowed submission types Log in as the student Go to the assignment and click to add a submission Open the browser console In the "online text" section of the submission form click on the media button (looks like a film camera) in the editor toolbar Confirm that the M.form.shortforms is not a function error is not reported in the browser console Click the "video" tab in the insert media modal Confirm that each of the collapsible regions (Display options, Advanced settings, Subtitles and captions) in the short form can be expanded and collapsed
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59399-master
    • Pull Master Diff URL:

      Description

      1. Click on "Insert media" button in Atto while submitting online text for assignments. 
      2. Click on either "Video" or "Audio" tab in atto
      3. There is no way to expand collapsible items (i.e. Display options, Advanced settings, Subtitiles and captions)

      The following javascript error occurs: 

      M.form.shortforms is not a function. (In 'M.form.shortforms({formid:this.get("host").get("elementid")+"_atto_media_form"})', 'M.form.shortforms' is undefined)

      This is probably because shortforms are disabled in assignments (/mod/assign/locallib.php)?

        Attachments

          Activity

            People

            Assignee:
            ryanwyllie Ryan Wyllie
            Reporter:
            karasic Olga Karaseva
            Peer reviewer:
            Andrew Lyons Andrew Lyons
            Integrator:
            David Monllaó David Monllaó
            Tester:
            Damyon Wiese Damyon Wiese
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/17