Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59427

MUC: cache_helper::purge_all does not reset adhoc caches

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Caching, Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      This back-end behaviour does not cause known practical problems with current Moodle code so there is no way to reproduce it with manual testing. The change includes a new PHPunit test, which you can run as:

      vendor/bin/phpunit cache/tests/cache_test.php

       

      Show
      This back-end behaviour does not cause known practical problems with current Moodle code so there is no way to reproduce it with manual testing. The change includes a new PHPunit test, which you can run as: vendor/bin/phpunit cache/tests/cache_test.php  
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-59427-master

      Description

      If you make an ad-hoc cache using cache::make_from_params, this is not reset by cache_helper:purge_all. As a result, these caches can persist between PHPunit test runs.

      I think cache_helper:purge_all should delete the adhoc caches. I'll see if it is easy to code this.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                quen Sam Marshall
                Reporter:
                quen Sam Marshall
                Peer reviewer:
                Tim Hunt
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                CiBoT
                Participants:
                Component watchers:
                Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17