Loading...

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE
Fixed Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
wip-~~MDL-59441~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/5a651b43fb...wip-MDL-59441-master
Testing Instructions:
1. Remove /tests/ folder from one of the modules
2. Run unittest calendar/tests/container_test.php (calendar/tests/lib_test.php on Moodle 3.2)

Running phpunit tests on a system with non-standard plugins fails on the first plugin that is missing a tests/generator/lib.php file

The reason is line 299 of calendar/tests/container_test.php

$module = $this->getDataGenerator()->create_module($modname, ['course' => $course->id]);

A try... catch or if(this->getDataGenerator()) check will be necessary for contrib plugins.

is a regression caused by

MDL-59308 Course_delete_module function deletes module instance which still need to exist for event removal.

is duplicated by

MDL-59474 PHP UNIT tests fail if an activity module doesn't have test module generator

Participants:: Adrian Greeve, Ankit Agarwal, CiBoT, David Monllaó, Jake Dallimore, Marina Glancy, Renaat Debleu