Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59448

Bootstrap's *-info styles clash with accessibility requirements and with changes to $brand-primary

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.4
    • 3.2.3, 3.3.2, 3.4
    • Accessibility, Themes
    • MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • MOODLE_34_STABLE
    • MDL-59448-master
    • Hide
      1. Add some interests to your user profile
      2. Make sure they display purple and the help icons too
      3. Mark a section in a course as hidden
      4. Make sure the text below it appears purple
      5. Go to Site administration > Appearance > Themes > Boost
      6. Click advanced settings
      7. Paste $brand-info: #00FFFF !default into Raw initial SCSS.
      8. Save
      9. Click the purge caches link down the bottom
      10. Edit your profile
      11. Make sure the interests are cyan
      12. Go to the course you edited before
      13. Make sure the hidden text appears cyan
      Show
      Add some interests to your user profile Make sure they display purple and the help icons too Mark a section in a course as hidden Make sure the text below it appears purple Go to Site administration > Appearance > Themes > Boost Click advanced settings Paste $brand-info: #00FFFF !default into Raw initial SCSS. Save Click the purge caches link down the bottom Edit your profile Make sure the interests are cyan Go to the course you edited before Make sure the hidden text appears cyan
    • 3.4 Sprint 3

      When reviewing MDL-58889 it became clear that things like text-info and tag-info were using the bootstrap color scheme of white over the background of #5bc0de. Whilst this looks fine without MDL-58889 applied (coincidence), it becomes a little yucky when that patch is applied (it also doesn't meet AA http://webaim.org/resources/contrastchecker/). Changing brand-primary doesn't change these, but really they should be related.

      This issue must be addressed alongside MDL-58889.

        1. purple_questions.png
          purple_questions.png
          45 kB
        2. purple icon.png
          purple icon.png
          6 kB
        3. purple labels.png
          purple labels.png
          26 kB
        4. purple-red-form-element.png
          purple-red-form-element.png
          1 kB
        5. Screen Shot 2017-07-25 at 1.38.13 pm.png
          Screen Shot 2017-07-25 at 1.38.13 pm.png
          37 kB
        6. Screen Shot 2017-07-25 at 1.38.38 pm.png
          Screen Shot 2017-07-25 at 1.38.38 pm.png
          34 kB

            johno John Okely
            jaked Jake Dallimore
            Dan Poltawski Dan Poltawski
            David Monllaó David Monllaó
            Ryan Wyllie Ryan Wyllie
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.