Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59448

Bootstrap's *-info styles clash with accessibility requirements and with changes to $brand-primary

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.3, 3.3.2, 3.4
    • Fix Version/s: 3.4
    • Component/s: Accessibility, Themes
    • Labels:
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59448-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. Add some interests to your user profile
      2. Make sure they display purple and the help icons too
      3. Mark a section in a course as hidden
      4. Make sure the text below it appears purple
      5. Go to Site administration > Appearance > Themes > Boost
      6. Click advanced settings
      7. Paste $brand-info: #00FFFF !default into Raw initial SCSS.
      8. Save
      9. Click the purge caches link down the bottom
      10. Edit your profile
      11. Make sure the interests are cyan
      12. Go to the course you edited before
      13. Make sure the hidden text appears cyan
      Show
      Add some interests to your user profile Make sure they display purple and the help icons too Mark a section in a course as hidden Make sure the text below it appears purple Go to Site administration > Appearance > Themes > Boost Click advanced settings Paste $brand-info: #00FFFF !default into Raw initial SCSS. Save Click the purge caches link down the bottom Edit your profile Make sure the interests are cyan Go to the course you edited before Make sure the hidden text appears cyan
    • Sprint:
      3.4 Sprint 3

      Description

      When reviewing MDL-58889 it became clear that things like text-info and tag-info were using the bootstrap color scheme of white over the background of #5bc0de. Whilst this looks fine without MDL-58889 applied (coincidence), it becomes a little yucky when that patch is applied (it also doesn't meet AA http://webaim.org/resources/contrastchecker/). Changing brand-primary doesn't change these, but really they should be related.

      This issue must be addressed alongside MDL-58889.

        Attachments

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-63218 Default *-info back from purple to blue

          • Minor - Minor loss of function where workaround is possible
          • Open
          has to be finished together with

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-58889 Accessibility Problems with Boost Theme for 3.2: section titles and course title links

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-58889 Accessibility Problems with Boost Theme for 3.2: section titles and course title links

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59782 Question bank highlight of last added question is wrong in boost

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              johno John Okely
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Dan Poltawski Dan Poltawski
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Ryan Wyllie Ryan Wyllie
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17