Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59457

Activity completion "Require passing grade" is not working accurately without "Require grade"

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Won't Do
    • 3.1.6, 3.3.3, 3.4
    • None
    • Activity completion, Quiz
    • MOODLE_31_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE

    Description

      Calculation the "completion state for an activity and user" (internal_get_state method in completionlib.php) cheks grade state only if completiongradeitemnumber was set to cm.

      But $cm->completiongradeitemnumber is null when activity completion settings are:

      • Require grade - false
      • Require passing grade - true

      So, we expext completionstate == COMPLETION_COMPLETE_PASS (2) or COMPLETION_COMPLETE_FAIL (3), but we take always only COMPLETION_COMPLETE (1)

       

      The problem occured when we using availability condition "completion" and waiting passed modules to give availability to user. Modules are always just COMPLETION_COMPLETE and never goes to COMPLETION_COMPLETE_PASS. 

      Attachments

        1. image-2020-10-06-12-55-06-504.png
          image-2020-10-06-12-55-06-504.png
          19 kB
        2. image-2020-10-06-12-57-54-219.png
          image-2020-10-06-12-57-54-219.png
          16 kB
        3. moodle bug 1.JPG
          moodle bug 1.JPG
          48 kB
        4. moodle bug 2.JPG
          moodle bug 2.JPG
          22 kB
        5. moodle bug 3.JPG
          moodle bug 3.JPG
          31 kB
        6. moodle bug 4.png
          moodle bug 4.png
          34 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              d.shtolin Dmitrii Shtolin
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona), Tim Hunt, Amaia Anabitarte, Brett Dalton, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Kevin Percy, Laurent David, Mathew May, Mihail Geshoski, Sabina Abellan, Sara Arjona (@sarjona), Shamim Rezaie
              Votes:
              7 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: