Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59499

Category Management JS error when using font awesome icons

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3, 3.3.1
    • Fix Version/s: 3.3.2
    • Component/s: Administration, JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up categories and sub categories
      2. Visit category management page.
      3. Expand a category list
      4. Collapse the category list
        1. The category is expanded and the image changes to reflect this.
        2. The category is collapsed and the image changes back to reflect this
      Show
      Set up categories and sub categories Visit category management page. Expand a category list Collapse the category list The category is expanded and the image changes to reflect this. The category is collapsed and the image changes back to reflect this
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59499_master_category_collapse_js_fix

      Description

      When expanding and collapsing categories on the course management page, the collapse event causes and JS error and the image does not get replaced.

      This occurs when using a theme that uses the font awesome icons.

      It seems the expansion JS was updated in MDL-40759 , but the collapse function was missed.

      To reproduce:

      1. Set up categories and sub categories
      2. Visit category management page.
      3. Expand a category list
      4. Collapse the category list

      Current Result:
      The category is expanded and the image changes to reflect this.
      The category is collapsed BUT the image does not change back to reflect this

      Expected Result:
      The category is expanded and the image changes to reflect this.
      The category is collapsed and the image changes back to reflect this

       

        Attachments

          Activity

            People

            Assignee:
            iamandrew Andrew Davidson
            Reporter:
            iamandrew Andrew Davidson
            Peer reviewer:
            Andrew Nicols
            Integrator:
            David Monllaó
            Tester:
            Jake Dallimore
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Sep/17