Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59567

The network servers block should use html_writer

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.5
    • Component/s: Blocks, MNet
    • Labels:
    • Testing Instructions:
      Hide

      To test this you will need two moodle instances, Moodle A and Moodle B. Steps as a site administrator:

      1. Follow the steps in https://docs.moodle.org/34/en/MNet for enabling SSO between Moodle A and Moodle B using Mnet.
      2. Navigate to Site home on Moodle A and turn editing on. Add the Network Servers block.
      3. Verify that the block lists Moodle B and that only the server name is underlined. Depending on the theme you might have to hover in order to verify this.
      Show
      To test this you will need two moodle instances, Moodle A and Moodle B. Steps as a site administrator: Follow the steps in https://docs.moodle.org/34/en/MNet  for enabling SSO between Moodle A and Moodle B using Mnet. Navigate to Site home on Moodle A and turn editing on. Add the Network Servers block. Verify that the block lists Moodle B and that only the server name is underlined. Depending on the theme you might have to hover in order to verify this.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59567-master

      Description

      The network servers block (block_mnet_hosts) generates its links manually. This is suboptimal, especially because of the manual space between the icon and text which looks odd if your theme underlines links.

        Attachments

          Activity

            People

            • Assignee:
              cfulton Charles Fulton
              Reporter:
              cfulton Charles Fulton
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Andrew Nicols
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Adrian Greeve, Mihail Geshoski, Peter Dias
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18