Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59578

Unnecessary steps in lib/tests/behat/alpha_chooser.feature

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59578-master
    • Testing Instructions:
      Hide
      1. Run Behat test for lib/tests/behat/alpha_chooser.feature.
        • Confirm that it passes.
      Bonus
      1. Compare the Behat test run times for lib/tests/behat/alpha_chooser.feature before and after the patch.
        • Confirm that the run time after the patch is a little faster.
      Show
      Run Behat test for lib/tests/behat/alpha_chooser.feature. Confirm that it passes. Bonus Compare the Behat test run times for lib/tests/behat/alpha_chooser.feature before and after the patch. Confirm that the run time after the patch is a little faster.

      Description

      The following steps at the end of the Background section of the feature file seem unnecessary. They don't make sense and just adds to the execution time of the test:

          And I log in as "student1"
          And I am on "Course 1" course homepage
          And I log out
          And I log in as "student2"
          And I am on "Course 1" course homepage
          And I log out
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Ankit Agarwal Ankit Agarwal
              Integrator:
              David Monllaó David Monllaó
              Tester:
              John Okely John Okely
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Sep/17