Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59578

Unnecessary steps in lib/tests/behat/alpha_chooser.feature

    XMLWordPrintable

Details

    • MOODLE_33_STABLE
    • MOODLE_33_STABLE
    • MDL-59578-master
    • Hide
      1. Run Behat test for lib/tests/behat/alpha_chooser.feature.
        • Confirm that it passes.
      Bonus
      1. Compare the Behat test run times for lib/tests/behat/alpha_chooser.feature before and after the patch.
        • Confirm that the run time after the patch is a little faster.
      Show
      Run Behat test for lib/tests/behat/alpha_chooser.feature. Confirm that it passes. Bonus Compare the Behat test run times for lib/tests/behat/alpha_chooser.feature before and after the patch. Confirm that the run time after the patch is a little faster.

    Description

      The following steps at the end of the Background section of the feature file seem unnecessary. They don't make sense and just adds to the execution time of the test:

          And I log in as "student1"
      		 
          And I am on "Course 1" course homepage
      		 
          And I log out
      		 
          And I log in as "student2"
      		 
          And I am on "Course 1" course homepage
      		 
          And I log out

      Attachments

        Issue Links

          caused a regression

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-59658 Random behat fails in alphachooser

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-59436 Remove the columns from the participants page that are not in showuseridentity

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              jpataleta Jun Pataleta
              jpataleta Jun Pataleta
              Ankit Agarwal Ankit Agarwal
              David Monllaó David Monllaó
              John Okely John Okely
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Sep/17