[MDL-59583] MariaDB 10.2.7 breaks dml unit tests - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.2.4, 3.3.1, 3.4
Fix Version/s: 3.2.5, 3.3
Component/s: Database SQL/XMLDB, Unit tests
Labels:
- ci
- triaged
Environment:
MariaDB 10.2.7

Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Epic Link:
MySQL-8.0
Pull from Repository:
https://github.com/scara/moodle/
Pull Master Branch:
m34_~~MDL-59583~~_Fix_MariaDB_10d2d7_Breaking_Change
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/229ae61...scara:m34_MDL-59583_Fix_MariaDB_10d2d7_Breaking_Change
Testing Instructions:
Hide

(difficulty: medium, requires MariaDB 10.2.7 or above)

Install Moodle on MariaDB 10.2.7 (Docker: mariadb:10.2.7), e.g. using https://github.com/danpoltawski/moodle-docker but locally reverting https://github.com/danpoltawski/moodle-docker/commit/354a36f2cb1515b48b3dac5a891c4d3c4ad0a949

Run DML tests (vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php).
In the Docker composition above, the command is: bin/moodle-docker-compose exec -T webserver vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php

Regression tests, do the same with:

MariaDB 10.2.6 or below

MySQL 5.7
Show
(difficulty: medium, requires MariaDB 10.2.7 or above) Install Moodle on MariaDB 10.2.7 (Docker: mariadb:10.2.7 ), e.g. using https://github.com/danpoltawski/moodle-docker but locally reverting https://github.com/danpoltawski/moodle-docker/commit/354a36f2cb1515b48b3dac5a891c4d3c4ad0a949 Run DML tests ( vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php ). In the Docker composition above, the command is: bin/moodle-docker-compose exec -T webserver vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php Regression tests, do the same with: MariaDB 10.2.6 or below MySQL 5.7

Description

MariaDB 10.2.7 unit tests fail, where 10.2.6 passes

10.2.7 is newly released and we discovered using the mariadb:10.2.7 docker image https://github.com/danpoltawski/docker-moodle/issues/25

Moodle 3.4dev (Build: 20170707), fdd9e4187a8f5e6ffe44eef11472de81c756ecef

Php: 7.1.6, mariadb: 10.2.7, OS: Linux 4.9.31-moby x86_64

PHPUnit 5.5.7 by Sebastian Bergmann and contributors.

.........F.....................................................  63 / 103 ( 61%)

........................................                        103 / 103 (100%)

Time: 50.86 seconds, Memory: 36.00MB

There was 1 failure:

1) core_dml_testcase::test_get_columns

Failed asserting that two strings are identical.

--- Expected

+++ Actual

@@ @@

-lala

+'lala'

/var/www/html/lib/dml/tests/dml_test.php:716

/var/www/html/lib/phpunit/classes/database_driver_testcase.php:143

To re-run:

 vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php

FAILURES!

Tests: 103, Assertions: 1121, Failures: 1.

Attachments

Issue Links

caused a regression

MDL-69973 mariadb returns wrong defaults from RDBMS metadata (plus caching issue)

Closed

has been marked as being related by

MDL-63252 XMLDB check defaults returns false warnings

Closed

Testing discovered

MDL-59701 MariaDB 10.2.7 breaks ddl unit tests

Closed

Activity

People

Assignee:: Matteo Scaramuccia

Reporter:: Dan Poltawski

Peer reviewer:: Dan Poltawski

Integrator:: Andrew Lyons

Tester:: Mark Nelson

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Mark Nelson, Matteo Scaramuccia

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 2 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 20/Jul/17 11:58 PM

Updated:: 18/Oct/20 5:19 PM

Resolved:: 04/Aug/17 10:02 PM

Fix Release Date:: 15/May/17