Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59583

MariaDB 10.2.7 breaks dml unit tests

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      (difficulty: medium, requires MariaDB 10.2.7 or above)

      1. Install Moodle on MariaDB 10.2.7 (Docker: mariadb:10.2.7), e.g. using https://github.com/danpoltawski/moodle-docker but locally reverting https://github.com/danpoltawski/moodle-docker/commit/354a36f2cb1515b48b3dac5a891c4d3c4ad0a949
      2. Run DML tests (vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php).
        In the Docker composition above, the command is: bin/moodle-docker-compose exec -T webserver vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php
      3. Regression tests, do the same with:
        • MariaDB 10.2.6 or below
        • MySQL 5.7
      Show
      (difficulty: medium, requires MariaDB 10.2.7 or above) Install Moodle on MariaDB 10.2.7 (Docker: mariadb:10.2.7 ), e.g. using https://github.com/danpoltawski/moodle-docker but locally reverting https://github.com/danpoltawski/moodle-docker/commit/354a36f2cb1515b48b3dac5a891c4d3c4ad0a949 Run DML tests ( vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php ). In the Docker composition above, the command is: bin/moodle-docker-compose exec -T webserver vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php Regression tests, do the same with: MariaDB 10.2.6 or below MySQL 5.7
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
       m34_MDL-59583_Fix_MariaDB_10d2d7_Breaking_Change

      Description

      MariaDB 10.2.7 unit tests fail, where 10.2.6 passes

      10.2.7 is newly released and we discovered using the mariadb:10.2.7 docker image https://github.com/danpoltawski/docker-moodle/issues/25

      Moodle 3.4dev (Build: 20170707), fdd9e4187a8f5e6ffe44eef11472de81c756ecef
      Php: 7.1.6, mariadb: 10.2.7, OS: Linux 4.9.31-moby x86_64
      PHPUnit 5.5.7 by Sebastian Bergmann and contributors.
       
      .........F.....................................................  63 / 103 ( 61%)
      ........................................                        103 / 103 (100%)
       
      Time: 50.86 seconds, Memory: 36.00MB
       
      There was 1 failure:
       
      1) core_dml_testcase::test_get_columns
      Failed asserting that two strings are identical.
      --- Expected
      +++ Actual
      @@ @@
      -lala
      +'lala'
       
      /var/www/html/lib/dml/tests/dml_test.php:716
      /var/www/html/lib/phpunit/classes/database_driver_testcase.php:143
       
      To re-run:
       vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php
       
      FAILURES!
      Tests: 103, Assertions: 1121, Failures: 1.
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/17