Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59596

Unit test failure with MariaDB/MySQL8

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Testing performed via Unit Tests, at least DDL, targetting each one of the 5 supported DB: vendor/bin/phpunit core_ddl_testcase lib/ddl/tests/ddl_test.php
      2. (Regressions) The same tests above should be run on both MariaDB versions crossing the SQL_MODE breaking change i.e. selecting one version among 10.2.3- e.g. 10.1.26 and one among 10.2.4+ e.g. 10.2.8
      Show
      Testing performed via Unit Tests, at least DDL, targetting each one of the 5 supported DB: vendor/bin/phpunit core_ddl_testcase lib/ddl/tests/ddl_test.php (Regressions) The same tests above should be run on both MariaDB versions crossing the  SQL_MODE breaking change i.e. selecting one version among 10.2.3- e.g. 10.1.26 and one among 10.2.4+ e.g. 10.2.8
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      m35_MDL-59596_DDL_Issues_With_MariaDB_10p2_SQLMode

      Description

       
      Time: 17.92 minutes, Memory: 318.00MB
       
      There was 1 error:
       
      1) core_ddl_testcase::test_change_field_type
      ddl_change_structure_exception: DDL sql execution error (Truncated incorrect INTEGER value: '4.0000000000'
      ALTER TABLE t_test_table_cust0 MODIFY COLUMN anothernumber BIGINT(10) NOT NULL DEFAULT 10)
       
      /var/www/html/lib/dml/moodle_database.php:492
      /var/www/html/lib/dml/mysqli_native_moodle_database.php:1000
      /var/www/html/lib/ddl/database_manager.php:77
      /var/www/html/lib/ddl/database_manager.php:595
      /var/www/html/lib/ddl/tests/ddl_test.php:1101
      /var/www/html/lib/phpunit/classes/database_driver_testcase.php:143
       
      To re-run:
       vendor/bin/phpunit --verbose core_ddl_testcase lib/ddl/tests/ddl_test.php
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/18