[MDL-59596] Unit test failure with MariaDB/MySQL8 - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Epic Link:
MySQL-8.0
Pull from Repository:
https://github.com/scara/moodle/
Pull Main Branch:
m35_~~MDL-59596~~_DDL_Issues_With_MariaDB_10p2_SQLMode
Pull Main Diff URL:
https://github.com/scara/moodle/compare/a15c7459360f220a34c138f808340e3848c85b7c...m35_MDL-59596_DDL_Issues_With_MariaDB_10p2_SQLMode
Testing Instructions:
Hide

Testing performed via Unit Tests, at least DDL, targetting each one of the 5 supported DB: vendor/bin/phpunit core_ddl_testcase lib/ddl/tests/ddl_test.php

(Regressions) The same tests above should be run on both MariaDB versions crossing the SQL_MODE breaking change i.e. selecting one version among 10.2.3- e.g. 10.1.26 and one among 10.2.4+ e.g. 10.2.8
Show
Testing performed via Unit Tests, at least DDL, targetting each one of the 5 supported DB: vendor/bin/phpunit core_ddl_testcase lib/ddl/tests/ddl_test.php (Regressions) The same tests above should be run on both MariaDB versions crossing the SQL_MODE breaking change i.e. selecting one version among 10.2.3- e.g. 10.1.26 and one among 10.2.4+ e.g. 10.2.8

Time: 17.92 minutes, Memory: 318.00MB

There was 1 error:

1) core_ddl_testcase::test_change_field_type

ddl_change_structure_exception: DDL sql execution error (Truncated incorrect INTEGER value: '4.0000000000'

ALTER TABLE t_test_table_cust0 MODIFY COLUMN anothernumber BIGINT(10) NOT NULL DEFAULT 10)

/var/www/html/lib/dml/moodle_database.php:492

/var/www/html/lib/dml/mysqli_native_moodle_database.php:1000

/var/www/html/lib/ddl/database_manager.php:77

/var/www/html/lib/ddl/database_manager.php:595

/var/www/html/lib/ddl/tests/ddl_test.php:1101

/var/www/html/lib/phpunit/classes/database_driver_testcase.php:143

To re-run:

 vendor/bin/phpunit --verbose core_ddl_testcase lib/ddl/tests/ddl_test.php

blocks

MDL-61702 Can't install Moodle version > 3.1 with mariaDB version >= 10.3.1

has a non-specific relationship to

MDL-59099 Row format options removed

is duplicated by

MDL-59701 MariaDB 10.2.7 breaks ddl unit tests

Participants:: Adrian Greeve, Andrew Lyons, CiBoT, David Monllaó, Eloy Lafuente (stronk7), Marina Glancy, Mark Nelson, Matteo Scaramuccia, Sam Hemelryk, Shamim Rezaie