Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59663

When all categories in combo list are expanded on page load the link still says "Expand all"

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Categories with subcategories
      1. Login as admin
      2. Go to Site administration / Courses / Manage courses and categories
      3. Create the following courses and categories structure:
        1. Top > Miscellaneous > Course 1
        2. Top > Miscellaneous > Subcategory 1
        3. Top > Category 1 > Course 2
      4. Navigate to Site home.
      5. Edit settings.
      6. Set the "Front page items when logged in" settings to the following:
        • Combo list
        • List of categories
      7. Save the change.
      8. Go back to Site home.
      9. Check the "Courses" section's expand/collapse all link
        • Confirm that expand/collapse all link is rendered as "Collapse all".
      10. Check the "Course categories" section's expand/collapse all link
        • Confirm that expand/collapse all link is rendered as "Collapse all".
      11. Click on the "Miscellaneous" course category link.
      12. Check the expand/collapse all link
        • Confirm that expand/collapse all link is rendered as "Expand all".
      13. Go to "/course/index.php"
      14. Check the expand/collapse all link
        • Confirm that expand/collapse all link is rendered as "Expand all".
      All top-level categories
      1. Go to Site administration / Courses / Manage courses and categories
      2. Edit the current courses and categories structure to something like:
        1. Top > Miscellaneous > Course 1
        2. Top > Subcategory 1
        3. Top > Category 1 > Course 2
      3. Navigate to Site home.
      4. Check the "Courses" section's expand/collapse all link
        • Confirm that expand/collapse all link is rendered as "Collapse all".
      5. Check the "Course categories" section's expand/collapse all link
        • Confirm that expand/collapse all link is rendered as "Expand all".
      6. Go to "/course/index.php"
      7. Check the expand/collapse all link
        • Confirm that expand/collapse all link is rendered as "Expand all".
      Show
      Categories with subcategories Login as admin Go to Site administration / Courses / Manage courses and categories Create the following courses and categories structure: Top > Miscellaneous > Course 1 Top > Miscellaneous > Subcategory 1 Top > Category 1 > Course 2 Navigate to Site home. Edit settings. Set the " Front page items when logged in " settings to the following: Combo list List of categories Save the change. Go back to Site home. Check the " Courses " section's expand/collapse all link Confirm that expand/collapse all link is rendered as " Collapse all ". Check the " Course categories " section's expand/collapse all link Confirm that expand/collapse all link is rendered as " Collapse all ". Click on the " Miscellaneous " course category link. Check the expand/collapse all link Confirm that expand/collapse all link is rendered as " Expand all ". Go to " /course/index.php " Check the expand/collapse all link Confirm that expand/collapse all link is rendered as " Expand all ". All top-level categories Go to Site administration / Courses / Manage courses and categories Edit the current courses and categories structure to something like: Top > Miscellaneous > Course 1 Top > Subcategory 1 Top > Category 1 > Course 2 Navigate to Site home. Check the " Courses " section's expand/collapse all link Confirm that expand/collapse all link is rendered as " Collapse all ". Check the " Course categories " section's expand/collapse all link Confirm that expand/collapse all link is rendered as " Expand all ". Go to " /course/index.php " Check the expand/collapse all link Confirm that expand/collapse all link is rendered as " Expand all ".
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59663-master

      Description

      Front page setting: Combo list

      When the front page loads, the "Expand all/Collapse all" link reads "Expand all", while the combo list is expanded. Clicking the link changes it to "Collapse all" while the list remains expanded. After that the link works as expected.

      For a demo see moodle@kreidestaub.de

        Attachments

        1. expandall.png
          expandall.png
          71 kB
        2. patch.txt
          0.8 kB

          Activity

            People

            Assignee:
            jpataleta Jun Pataleta
            Reporter:
            chessweb Ralf Seliger
            Peer reviewer:
            Mark Nelson
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Sep/17