Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59666

No validation for "Remind me to grade by" field in mod_assign

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.3.1
    • 3.3.2
    • Assignment
    • MOODLE_33_STABLE
    • MOODLE_33_STABLE
    • MDL-59666-master
    • Hide
      1. Login as a teacher and navigate to a course.
      2. Create an assignment.
      3. Set a value for the "Remind me to grade by" date and perform the various combinations of assignment dates with values later than the "Remind me to grade by date" and confirm that you see the following validation errors:
        Case allowsubmissionsfrom duedate cutoffdate Validation error
        1 N/A
        2 Remind me to grade by date cannot be earlier than the allow submissions from date.
        3 Remind me to grade by date cannot be earlier than the due date.
        4 Remind me to grade by date cannot be earlier than the due date.
        5 N/A
        6 Remind me to grade by date cannot be earlier than the allow submissions from date.
        7 Remind me to grade by date cannot be earlier than the due date.
        8 Remind me to grade by date cannot be earlier than the due date.
      Show
      Login as a teacher and navigate to a course. Create an assignment. Set a value for the "Remind me to grade by" date and perform the various combinations of assignment dates with values later than the "Remind me to grade by date" and confirm that you see the following validation errors: Case allowsubmissionsfrom duedate cutoffdate Validation error 1 N/A 2 Remind me to grade by date cannot be earlier than the allow submissions from date. 3 Remind me to grade by date cannot be earlier than the due date. 4 Remind me to grade by date cannot be earlier than the due date. 5 N/A 6 Remind me to grade by date cannot be earlier than the allow submissions from date. 7 Remind me to grade by date cannot be earlier than the due date. 8 Remind me to grade by date cannot be earlier than the due date.

    Description

      You can set a value for the "Remind me to grade by" field in the assignment settings form which is before the allow submissions from/due-/cutoff- dates.

      I think it makes sense that the grading due date to be validated as follows:

      allowsubmissionsfrom duedate Validation method
      N/A
      gradingduedate >= allowsubmissionsfrom
      gradingduedate >= duedate
      gradingduedate >= duedate

      ||||gradingduedate >= cutoff|
      ||||gradingduedate >= cutoff|
      ||||gradingduedate >= cutoff|
      ||||gradingduedate >= cutoff|

      Attachments

        Activity

          People

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Simey Lameze Simey Lameze
            Dan Poltawski Dan Poltawski
            Adrian Greeve Adrian Greeve
            Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              11/Sep/17