Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59666

No validation for "Remind me to grade by" field in mod_assign

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.3.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as a teacher and navigate to a course.
      2. Create an assignment.
      3. Set a value for the "Remind me to grade by" date and perform the various combinations of assignment dates with values later than the "Remind me to grade by date" and confirm that you see the following validation errors:
        Case allowsubmissionsfrom duedate cutoffdate Validation error
        1 N/A
        2 Remind me to grade by date cannot be earlier than the allow submissions from date.
        3 Remind me to grade by date cannot be earlier than the due date.
        4 Remind me to grade by date cannot be earlier than the due date.
        5 N/A
        6 Remind me to grade by date cannot be earlier than the allow submissions from date.
        7 Remind me to grade by date cannot be earlier than the due date.
        8 Remind me to grade by date cannot be earlier than the due date.
      Show
      Login as a teacher and navigate to a course. Create an assignment. Set a value for the "Remind me to grade by" date and perform the various combinations of assignment dates with values later than the "Remind me to grade by date" and confirm that you see the following validation errors: Case allowsubmissionsfrom duedate cutoffdate Validation error 1 N/A 2 Remind me to grade by date cannot be earlier than the allow submissions from date. 3 Remind me to grade by date cannot be earlier than the due date. 4 Remind me to grade by date cannot be earlier than the due date. 5 N/A 6 Remind me to grade by date cannot be earlier than the allow submissions from date. 7 Remind me to grade by date cannot be earlier than the due date. 8 Remind me to grade by date cannot be earlier than the due date.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59666-master

      Description

      You can set a value for the "Remind me to grade by" field in the assignment settings form which is before the allow submissions from/due-/cutoff- dates.

      I think it makes sense that the grading due date to be validated as follows:

      allowsubmissionsfrom duedate Validation method
      N/A
      gradingduedate >= allowsubmissionsfrom
      gradingduedate >= duedate
      gradingduedate >= duedate

      ||||gradingduedate >= cutoff|
      ||||gradingduedate >= cutoff|
      ||||gradingduedate >= cutoff|
      ||||gradingduedate >= cutoff|

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Sep/17