Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59671

Prevent editing and deleting of activity calendar events

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Go to a existing course or create a new one.
      3. Click to add an activity that generates action events, such Lesson.
      4. On the form, expand Availability, enable and set Available From and Deadline.
      5. Save it.
      6. Run cron.
      7. Enrol admin in the course as student.
      8. Go to Calendar.
      9. Click in one of the two actions event generated.
      10. You should see just an Edit button, the Delete button should not be displayed.
      11. Click on the Edit button, make sure you are redirected to relative module edit page.
      12. Try other event types, such site and user, it should display the event edit form on the modal.
      REGRESSION TEST (FILTERS)
      1. On the Calendar, click on New event button.
      2. With the form opened, click More button.
      3. On the description field, click *Show more buttons" narrow icon.
      4. Click the </> HTML icon.
      5. Add the following description:

        The circle is defined by the location of the centre \(({x_0},{y_0})\) and the radius of the circle (r). Note that in the relation above, the centre is defined to be positive values of x0 and y0. Important and useful relations: \[\begin{array}{l}Area = \pi {r^2}\\Circumference = 2\pi r\\Arc{\rm{ }}length = r\theta \end{array}\]
        

      6. Click on Save button.
      7. Back on the Calendar, click to view the event.
      8. Make sure the Mathjax filter still works, and it rendered the equation properly.
      9. You should be able to see Edit and Delete buttons.
      REGRESSION TEST (EVENT SOURCE)
      1. Click on Manage subscription button on the calendar page.
      2. Select Import from Calendar file (.ics)
      3. Choose the ics file on calendar/test/fixtures and import it.
      4. Go to Feb 2017 on the calendar.
      5. Click on Event on 2-15-2017.
      6. Make sure it displays Event source: followed by THE CALENDAR NAME YOU SET ON THE IMPORT.
      Show
      Log in as admin Go to a existing course or create a new one. Click to add an activity that generates action events, such Lesson. On the form, expand Availability, enable and set Available From and Deadline. Save it. Run cron. Enrol admin in the course as student. Go to Calendar. Click in one of the two actions event generated. You should see just an Edit button, the Delete button should not be displayed. Click on the Edit button, make sure you are redirected to relative module edit page. Try other event types, such site and user, it should display the event edit form on the modal. REGRESSION TEST (FILTERS) On the Calendar, click on New event button. With the form opened, click More button. On the description field, click *Show more buttons" narrow icon. Click the </> HTML icon. Add the following description: The circle is defined by the location of the centre \(({x_0},{y_0})\) and the radius of the circle (r). Note that in the relation above, the centre is defined to be positive values of x0 and y0. Important and useful relations: \[\begin{array}{l}Area = \pi {r^2}\\Circumference = 2\pi r\\Arc{\rm{ }}length = r\theta \end{array}\] Click on Save button. Back on the Calendar, click to view the event. Make sure the Mathjax filter still works, and it rendered the equation properly. You should be able to see Edit and Delete buttons. REGRESSION TEST (EVENT SOURCE) Click on Manage subscription button on the calendar page. Select Import from  Calendar file (.ics) Choose the ics file on calendar/test/fixtures and import it. Go to Feb 2017 on the calendar. Click on Event on 2-15-2017 . Make sure it displays Event source: followed by THE CALENDAR NAME YOU SET ON THE IMPORT.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59671-master

      Description

      At the moment you can edit / delete calendar events created by an activity using the new modal interfaces but you shouldn't be able to

        Attachments

          Activity

            People

            Assignee:
            lameze Simey Lameze
            Reporter:
            ryanwyllie Ryan Wyllie
            Peer reviewer:
            Jun Pataleta
            Integrator:
            Andrew Nicols
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/17