Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59691

Annotated PDF comment marker icons appear in the wrong location

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.3, 3.3.1, 3.3.2
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      • Create an assignment with file submissions enabled.
      • As a student, submit a document to the assignment.
      • As a teacher, grade the submission and annotate a few comments.
      • Include some long comments close to the top and bottom boundaries of the page.
      • Verify that each comment collapses to a marker icon which is positioned at the top-left corner of the comment.
      • Verify that the location of the icon now indicates fairly accurately the text that the comment relates to, without needing to be moved afterwards.
      • Verify that comments collapse to a marker icon whilst being dragged, except when the 'expand all comments' toggle is enabled.
      • Verify that comment icons can be dragged right to the edge of the document on all 4 sides, and into the 4 corners of the document.
      • Verify that on tablet devices, collapsed comments can be dragged with a single touch/drag gesture, without having to be selected first and without taking focus (and therefore without popping up the keyboard on Android devices).
      • Verify that comments and comment menus can still be expanded and selected as normal with a single tap on tablet devices.
      • Verify that all of the above works with both the Clean and Boost themes.
      Show
      Create an assignment with file submissions enabled. As a student, submit a document to the assignment. As a teacher, grade the submission and annotate a few comments. Include some long comments close to the top and bottom boundaries of the page. Verify that each comment collapses to a marker icon which is positioned at the top-left corner of the comment. Verify that the location of the icon now indicates fairly accurately the text that the comment relates to, without needing to be moved afterwards. Verify that comments collapse to a marker icon whilst being dragged, except when the 'expand all comments' toggle is enabled. Verify that comment icons can be dragged right to the edge of the document on all 4 sides, and into the 4 corners of the document. Verify that on tablet devices, collapsed comments can be dragged with a single touch/drag gesture, without having to be selected first and without taking focus (and therefore without popping up the keyboard on Android devices). Verify that comments and comment menus can still be expanded and selected as normal with a single tap on tablet devices. Verify that all of the above works with both the Clean and Boost themes.
    • Affected Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull 3.3 Branch:
    • Pull Master Branch:
      MDL-59691-master

      Description

      During the latter stages of development on -MDL-55459- a decision was made to position comment marker icons at the bottom-left corner of the comment rather than the top-left. It is now becoming apparent, as we test our 3.3 upgrade, that this was a mistake. There seem to be two fundamental issues, which affect both new and existing (pre-upgrade) comments:

      • Comments cannot be drawn (or moved) to extend beyond the top of the page, but they can extend below the bottom of the page. If a new comment is drawn anywhere on a page, the comment box will naturally extend down the page as the teacher types, and will therefore collapse to a marker icon further down the page than was intended (much more so after saving the grading changes, which is a separate bug in itself). The teacher will then attempt to move the comment back up the page to make the icon appear in the correct location, but in the case of comments located close to the top of the page, will be restricted from doing so by the top boundary. Even in the case of comments located further down the page, this seems like an unnecessary additional step and makes the whole process seem very unintuitive.
      • The natural tendency (at least amongst our teachers) seems to be to position a comment so that it starts at the point in the document that it relates to, so for existing pre-upgrade comments the new marker icon will usually end up much further down the page than the text it relates to, especially for long comments. Indeed for comments located towards the bottom of the page, the marker icon will often appear far below the bottom of the page.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated: